Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1975 +/- ##
==========================================
+ Coverage 89.91% 89.95% +0.04%
==========================================
Files 71 71
Lines 20182 20183 +1
==========================================
+ Hits 18145 18153 +8
+ Misses 2037 2030 -7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the Happysocks integration to support an alternate Socket.IO namespace backed by ClickHouse, and wires the option through the BlazeMeter reporter configuration, with accompanying unit tests and changelog entries.
Changes:
- Add ClickHouse namespace support (
/v1/engine-ch) and make namespace selection configurable inHappysocksClient. - Expose
happysocks-use-clickhousein the BlazeMeter reporter and propagate it into Happysocks client creation. - Add/extend unit tests for ClickHouse namespace behavior, timeouts, connection state, and console
ScrollingLogbehavior.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
bzt/utils.py |
Adds ClickHouse namespace constant and routes connect/emit through the selected namespace. |
bzt/modules/blazemeter/blazemeter_reporter.py |
Introduces happysocks-use-clickhouse setting and passes it to HappysocksClient. |
bzt/modules/console.py |
Updates urwid imports (Padding/SimpleListWalker) to match current module paths. |
tests/unit/test_bza.py |
Adds coverage for ClickHouse namespace selection, timeouts propagation, and connected state. |
tests/unit/modules/test_blazeMeterUploader.py |
Adds coverage for reporter→Happysocks instantiation params, proxy propagation, and buffering behavior. |
tests/unit/modules/test_consoleStatusReporter.py |
Adds unit tests for ScrollingLog.update() behavior (ANSI stripping, sizing, replacement). |
site/dat/docs/changes/feat-support-for-clickhouse-happysocks-namespace.change |
Adds one-line change note for the feature. |
site/dat/docs/Changelog.md |
Adds release notes for the new namespace support and the new reporter setting. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each PR must conform to Developer's Guide.
Quick checklist:
site/dat/docs/changesdirectory, one-line note of change inside