Update to use PSET and to allow signing #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apoelstra
force-pushed
the
2025-10/pset-signer
branch
from
72ccfe2 to
07bb2da
Compare
|
I'm not yet sure whether there's a kind of ack that I can appropriately offer here, but I saw this PR's functionality demonstrated successfully against Liquid Testnet this afternoon, so informally I think it's great. |
Contributor
Author
|
I will pull it apart into separate PRs and try to get them merged. I'll make sure that this PR/branch remains usable and complete for purposes of doing end-to-end Simplicity program stuff. |
apoelstra
force-pushed
the
2025-10/pset-signer
branch
from
07bb2da to
4e73c48
Compare
apoelstra
force-pushed
the
2025-10/pset-signer
branch
2 times, most recently
from
af63781 to
8ce1fe2
Compare
Refactor the code a bit to allow parsing arbitrary strings as either hex or base 64.
We will want to be able to parse this format for PSET support.
If you provide a PSET instead of a raw transaction, then attempt to extract a transaction from it.
This command takes a PSET where we've updated all the inputs (with 'simplicity pset update-input' for example), as well as a program and a valid witness. It executes the program, prunes it, then adds it to the PSET. Then you can extract and send the program with elements-cli.
Now rather than extracting using elements-cli, by running
elements-cli finalizepsbt <psbt> true
you can do it with hal-simplicity, with
hal-simplicity simplicity pset extract <psbt>
apoelstra
force-pushed
the
2025-10/pset-signer
branch
from
8ce1fe2 to
010db0e
Compare
This should be compatible with any non-pegin non-issuance calls to elements-cli createpsbt. Co-authored-by: aider (anthropic/claude-sonnet-4-20250514) <[email protected]>
apoelstra
force-pushed
the
2025-10/pset-signer
branch
from
010db0e to
cacd1f7
Compare
Contributor
Author
delta1
approved these changes
Nov 27, 2025
| #[serde(with = "elements::bitcoin::amount::serde::as_btc")] | ||
| amount: elements::bitcoin::Amount, | ||
| }, | ||
| Map(HashMap<String, f64>), |
There was a problem hiding this comment.
Does this need a follow-up to support non-policy assets?
Contributor
Author
There was a problem hiding this comment.
I don't think so. This is the same as the elements-cli createpsbt interface. If you want non-policy assets then you need to use the verbose form of the command in the other enum variant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces several new PSET-manipulation commands to allow using this tool without needing an Elements daemon (other than for blockchain data access, which can be obtained from web APIs instead).
In particular we add:
simplicity pset update-inputwhich attaches Simplicity-related data to a specific inputsimplicity pset finalizewhich takes a Simplicity program and witness, executes and prunes the program, and attaches the data to the witnesssimplicity pset extractwhich constructs a complete transaction from a finalized PSETThis also extends
simplicity sighashto work with PSETs rather than requiring the user copy/paste tons of stuff in the CLI interface.