Skip to content

Conversation

@uncomputable
Copy link
Contributor

Create a new release for a version of the library that builds on WASM.

Copy link
Contributor

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 0e095e7; successfully ran local tests

@apoelstra apoelstra merged commit 7ab9405 into BlockstreamResearch:master Oct 21, 2024
12 of 14 checks passed
@apoelstra
Copy link
Contributor

Oops, sorry, I realize we actually need to release a new minor version of secp256k1-zkp-sys, not secp256k1-zkp, since the printf change was to -sys.

Can you make a new PR that reverts this and does that?

@uncomputable
Copy link
Contributor Author

I will be out flying for a while. I will look at this again after I land.

@uncomputable uncomputable mentioned this pull request Oct 24, 2024
apoelstra added a commit that referenced this pull request Oct 24, 2024
d96d701 chore: Bump version of secp256k1-zkp (Christian Lewe)
a8b4ae3 Revert "chore: release 0.11.1" (Christian Lewe)

Pull request description:

  Update the sys crate and revert the update of the parent crate. Fixes #87

ACKs for top commit:
  apoelstra:
    ACK d96d701

Tree-SHA512: 4a25d0a4d93ab4342090ab8f94735787999216fe1eb78ae82913afbe4dcd68c01b85a65d06fc95a612422cf928e8d4a04978ff9f09a63fb978c963dcad6b7fa7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants