Fixed 38 #112
Merged
Fixed 38 #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Captured the brief moment where the sidebar deployed but the profile navbar transition has not triggered yet |
FabulousCodingFox
force-pushed
the
fix-38
branch
from
7dbf35c to
e039954
Compare
FabulousCodingFox
force-pushed
the
fix-38
branch
from
e039954 to
a843764
Compare
|
The merge conflict has been resolved. Testing is still required to verify functionality. |
|
I intended to remove the unused |
|
I’ve completed the testing, and it’s now working as expected. |
|
The change works as expected from my testing aswell |
|
Preview deployed to https://c0fcd39f.academy-preview.pages.dev (total size: 15M) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have already tried to fix this bug by simply raising the sidebar above all other menus (see #26 ). There @Defelo suggested to close all other menus instead.
Since that pull, the dropdown menu in question has been given a function that closes it when interacting outside of it. Unfortunately, this does not solve the problem, as there are still artifacts or false overlaps in the transition. That's why I am nevertheless forced to raise the sidebar.
This can also not be prevented by adjusting the transition in NavbarMenu.vue so that it triggers directly and not only after 1000ms.
Type of change
Fixes Bootstrap-Academy/Bootstrap-Academy#38
My Bootstrap Academy username:
FabulousFox