Remove space deletion in input field #249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheMorpheus407
approved these changes
Aug 31, 2024
Defelo
reviewed
Sep 2, 2024
There was a problem hiding this comment.
Not sure we really want this. See Bootstrap-Academy/Bootstrap-Academy#102 (comment)
There was a problem hiding this comment.
Looks fine to me, to be honest. I tested it and it worked.
How about @Defelo ?
Did you also test 2FA on your system @Lauritz-Tieste ?
|
I have just tried it out: Entering the MFA code when activating and deactivating works as it should. demo.mp4 |
|
Looks good! Then @Defelo can test and merge if he's okay 👍 |
|
Preview deployed to https://3667d03a.academy-preview.pages.dev (total size: 15M) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes Bootstrap-Academy/Bootstrap-Academy#102