-
Notifications
You must be signed in to change notification settings - Fork 41
Issue#117: Sorting of self hosted courses #292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue#117: Sorting of self hosted courses #292
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working fine.
|
The current setting for stream_token_ttl is 8 hours. |
time span when a new video source is created reduced to match the current setting for stream_token_ttl (4000 Seconds -> 28800 Seconds / 8 hours )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BugsSindFeatures Thanks for the PR! One thing to note is that setInterval expects its timeout argument to be specified in milliseconds, so you just changed it to about 28 seconds, not 8 hours. However the real problem here is that switching to the new stream token no longer seems to work. After about 28 seconds after starting the video (e.g. here) the video just stops and resets, so this definititely needs to be fixed before this PR can be merged.
|
Thanks for the response! I corrected the argument from seconds to milliseconds. The described problem can be solved by Merging the pull request #289 because then the time will be automatically restored and to fix the problem that the Video stops if the source changed I added some code to prevent that. |
|
Preview deployed to https://053854a8.academy-preview.pages.dev (total size: 14M) |
|
@BugsSindFeatures Du darfst mir sehr gerne auch die Rechnung per Mail stellen - alle Infos dazu hier Danke fürs mitmachen! Und ich hoffe, du hattest Spaß und machst weiterhin mit :) |
Description
The Problem was that the video is rendered before the source of the video changed and the change of the video source didn't lead to a re-render of the video.
Changed key attribute of the video from "activelecture.id" to "videoSRC", so the video is re-rendered every time the video source changes.
In addition, the time span when a new video source is created was extended from 40 Seconds to 4000 Seconds so the Video is not re rendered every 40 Seconds.
I don't know if this will cause problems with the API because I don't know when the video source links expire.
Type of change
Fixes Bootstrap-Academy/Bootstrap-Academy#117
My Bootstrap Academy username: R4bbit