Skip to content

fix(angular): import paths for child components #1208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+126 −91
Open

fix(angular): import paths for child components #1208

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3e4b8a7
fix(angular): import paths for child components
sean-perkins Jun 21, 2023
d2928dc
refactor: move DEFAULT_OPTIONS into generator
sean-perkins Jun 22, 2023
b6a05e9
chore: update snapshots
sean-perkins Jun 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 32 additions & 1 deletion packages/core/src/generators/angular.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,6 +260,37 @@ const processAngularCode =
(newCode) => stripStateAndPropsRefs(newCode, { replaceWith }),
);

const defaultImportMapper = (standalone?: boolean) => {
return (_component: any, theImport: any, importedValues: any, componentsUsed: any) => {
let importPath = theImport.path;

const { defaultImport, namedImports, starImport } = importedValues;

let importValue;

if (starImport) {
importValue = ` * as ${starImport} `;
} else {
importValue = [defaultImport, namedImports]
.filter(Boolean)
.map((importName) => {
if (!standalone) {
for (const usedComponentName of componentsUsed || []) {
if ((importName || '').indexOf(usedComponentName) > -1) {
// replace the component name with the module name
return (importName || '').replace(usedComponentName, `${usedComponentName}Module`);
}
}
}
return importName;
})
.join(', ');
}

return `import ${importValue} from '${importPath}';`;
};
};

const DEFAULT_OPTIONS: ToAngularOptions = {
preserveImports: false,
preserveFileExtensions: false,
Expand Down Expand Up @@ -467,7 +498,7 @@ export const componentToAngular: TranspilerGenerator<ToAngularOptions> =
excludeMitosisComponents: !options.standalone && !options.preserveImports,
preserveFileExtensions: options.preserveFileExtensions,
componentsUsed,
importMapper: options?.importMapper,
importMapper: options?.importMapper || defaultImportMapper(options.standalone),
})}

@Component({
Expand Down