Fix/comments with quotes #1320
Fix/comments with quotes #1320
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 1573747. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targetsSent with 💌 from NxCloud. |
|
This is great! You just need to update test snapshots with your latest test: |
|
You also need to lint using |
All done now 👍🏾 |
| findAndRunScripts() { | ||
| // TODO: Move this function to standalone one in '@builder.io/utils' | ||
| if (this.$refs.elem && typeof window !== \\"undefined\\") { | ||
| /** @type {HTMLScriptElement[]} */ |
There was a problem hiding this comment.
One unwanted side-effect of your solution is that it removes all comments from all blocks. That would be a lot of useful content that we don't want to lose...
I will investigate a better approach.
There was a problem hiding this comment.
Opps, I guess I misunderstood this part, I thought it meant removing the comments from the whole code.
Expected behavior
Expect comments to be ignored/stripped before any Mitosis logic runs, and not cause any issues
There was a problem hiding this comment.
Sorry about that. The ideal expected behaviour is that comments never cause issues and that most comments make it to the final output.
There was a problem hiding this comment.
No worries, I'll look for another solution
2 participants
Description
Add a short description of:
{ comments: false }toparseCode,Side effects:
This change means that comments will always get removed
Note:
I've also updated an argument name from
xtonodeto make it more readable.