Implement the count optimization for the fallback implementation with SWAR (3-4x faster)
#183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dr-Emann
force-pushed
the
fallback_count_impl
branch
from
f94fd11 to
a3b3952
Compare
Closed
Dr-Emann
force-pushed
the
fallback_count_impl
branch
4 times, most recently
from
d85385c to
86fe7f9
Compare
|
@BurntSushi What are your thoughts on the kani checks, do you want them, or should I drop them? |
Dr-Emann
force-pushed
the
fallback_count_impl
branch
from
86fe7f9 to
c3f2eb8
Compare
Dr-Emann
changed the title
count optimization for the fallback implementation with SWARcount optimization for the fallback implementation with SWAR (3-4x faster)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the fallback optimized count implementation to rebar engines to compare. Appears to be quite a bit faster on my machine.
This also includes a
kanimodel checking harness to verify some of the SWAR functions (and a step to runcargo kaniin CI). Not sure if you'll want to pick it up or not, but it was nice to have confidence that it works for all values.rebar results
Results from my m1 macbook pro on macos
The fallback implementation is still definitely slower than the simd version (of course), but it's closer: