Extend search dialog to search by time #745
Conversation
vifactor
force-pushed
the
search-time
branch
3 times, most recently
from
111e01c to
67ec82c
Compare
vifactor
force-pushed
the
search-time
branch
3 times, most recently
from
ed140ea to
2203a21
Compare
vifactor
force-pushed
the
search-time
branch
from
2203a21 to
cfd25dc
Compare
|
The title of the Search Dialog is dlt-viewer. Can you change it to Search Settings? |
vifactor
force-pushed
the
search-time
branch
from
cfd25dc to
a3aa68e
Compare
#730 Signed-off-by: Viktor Kopp <[email protected]>
Set time range in search dialog on open take milliseconds into account Signed-off-by: Viktor Kopp <[email protected]>
SearchDialog remove unused variable convert heap var to stack var get rid of obsolete methods search dialog Implement simply RAII timer to measure and print search time Signed-off-by: Viktor Kopp <[email protected]>
Add cancel button to Search dialog Signed-off-by: Viktor Kopp <[email protected]>
vifactor
force-pushed
the
search-time
branch
from
a3aa68e to
9f405f8
Compare
Good catch, thanks, I made the dialog's header look the same way as in master.
I did this, even though it is basically new feature on its own. What I do not like about "Cancel"-button is that my expectation upon cancel would be "no state changed", but this is not what happens: yes, there is a difference between "OK" and "Cancel", that the latter does not trigger search, however, search params are saved on every interaction (old behavior), which means "Cancel" does not prevent storing them in the persistent settings. |
#730