Skip to content

Conversation

wr1159
Copy link

@wr1159 wr1159 commented Sep 24, 2024

Resolves #53
Filter questions by complexity and category

  • category currently is a search until we implement a schema / another end point where we can fetch the categories
  • complexity is a select

@wr1159 wr1159 self-assigned this Sep 24, 2024
Copy link

@SelwynAng SelwynAng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me overall but yarn build runs into error, similar to the one #129.

Screenshot 2024-09-26 at 12 11 50 PM

<SelectValue placeholder="Select complexity" />
</SelectTrigger>
<SelectContent>
<SelectItem value="all">All</SelectItem>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May can use a complexity schema, and then map over these fields?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using zod enum?

@wr1159 wr1159 merged commit 45ee483 into main Sep 27, 2024
2 checks passed
@wr1159 wr1159 deleted the feature/question-service/filter-questions branch September 27, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

F2.2.4 The service should allow filtering of questions by attributes like category, complexity.

2 participants