Skip to content

Conversation

jq1836
Copy link

@jq1836 jq1836 commented Sep 26, 2024

Resolves #39

Overview

Hooked up Save Changes button to make request to backend to update question.

image

@jq1836 jq1836 self-assigned this Sep 26, 2024
Copy link

@SelwynAng SelwynAng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, aside from nitpicks with the toast messages.

Aside from that, I realised that the user can keep clicking the "Save Changes" button even though there are no changes to the fields of the question and the success toast message will appear. Shall we disable the "Save Changes" button if no changes are made? We probably need to implement those states in the question form component.

Copy link

@wr1159 wr1159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wr1159 wr1159 merged commit 3994c62 into main Sep 27, 2024
2 checks passed
@wr1159 wr1159 deleted the feature/question-service/edit-question branch September 27, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

F2.1.9 The service should allow admin users to update questions through the frontend.

3 participants