-
Notifications
You must be signed in to change notification settings - Fork 0
Add ability to edit question in frontend #141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall, aside from nitpicks with the toast messages.
Aside from that, I realised that the user can keep clicking the "Save Changes" button even though there are no changes to the fields of the question and the success toast message will appear. Shall we disable the "Save Changes" button if no changes are made? We probably need to implement those states in the question form component.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Resolves #39
Overview
Hooked up Save Changes button to make request to backend to update question.