Skip to content

Conversation

@SelwynAng
Copy link

Resolves #142.

Changes made

  • Added new questions_exceptions.py file containing custom exceptions for our use cases with regards to question CRUD operations
  • Refactored routes and logic files to throw and handle exceptions to handle erroneous situations instead of relying on primitive string messages
  • Added return types for functions in routers/questions.py which were previously missing

@SelwynAng SelwynAng changed the title Add exception classes and refactor routers and service logic Question Service: Add exception classes and refactor routers and service logic Sep 27, 2024
Copy link

@TanPingZhi TanPingZhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MTGL

@TanPingZhi TanPingZhi merged commit d44df46 into main Sep 27, 2024
2 checks passed
@TanPingZhi TanPingZhi deleted the enhancement/question-service/refactor-add-exceptions branch September 27, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor question-service

3 participants