Skip to content

Add delete confirmation to user management #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 16, 2024
Merged

Add delete confirmation to user management #172

merged 4 commits into from
Oct 16, 2024

Conversation

dylkaw
Copy link

@dylkaw dylkaw commented Oct 16, 2024

Changes:

  • Admins now prompted for confirmation when deleting accounts
  • delete-account-modal.tsx is now a common component
  • Fixed bugs where confirmation input is not cleared, and modal does not close when deletion is confirmed

jq1836
jq1836 approved these changes Oct 16, 2024
View reviewed changes
Copy link

@jq1836 jq1836 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jq1836 jq1836 merged commit 2db6ce6 into main Oct 16, 2024
2 checks passed
@jq1836 jq1836 deleted the feature/user-management/delete-confirmation branch October 16, 2024 18:00
@TanPingZhi
Copy link

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jq1836 jq1836 jq1836 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dylkaw @TanPingZhi @jq1836