Skip to content

Conversation

SelwynAng
Copy link

Resolves #160.

Copy link

@jq1836 jq1836 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should technically work, assuming we call the endpoint accurately, so LGTM. I have added some suggestions for how we can improve on this to make it safer.

@SelwynAng SelwynAng force-pushed the fix/bug/login-fail-toast branch from 92d68a4 to d5b092f Compare October 19, 2024 05:13
@SelwynAng SelwynAng merged commit c13d229 into main Oct 20, 2024
2 checks passed
@SelwynAng SelwynAng deleted the fix/bug/login-fail-toast branch October 20, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

login failed toast should be clearer

2 participants