Skip to content

Conversation

Ryuse
Copy link

@Ryuse Ryuse commented Oct 14, 2025

For admins to see questions available on the question service.

Current features:

  • View/Filter Questions based on Category, DIfficulty, Timing
image
  • View Question Details
image

@Ryuse Ryuse self-assigned this Oct 14, 2025
@Ryuse Ryuse marked this pull request as ready for review October 15, 2025 10:26
Copy link

@xGladiate xGladiate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Currently the question-backend/routes.ts might seems a little long with 600 LOC due to the added API - we can consider looking into refactoring the code in another PR for better maintainability.

Might be able to improve on the UI side for the Admin Question but the current version works for now!

Another consideration is the design of UI for time limit --> do we want a slider bar? or fixed input (e.g. range from 15/30/45/60/120/240 mins to 15/30/45/60/120/240 mins). If we are sticking to the slider bar, we might want to consider increasing the slider button for easier sliding.

@Ryuse
Copy link
Author

Ryuse commented Oct 15, 2025

LGTM! Currently the question-backend/routes.ts might seems a little long with 600 LOC due to the added API - we can consider looking into refactoring the code in another PR for better maintainability.

Might be able to improve on the UI side for the Admin Question but the current version works for now!

Another consideration is the design of UI for time limit --> do we want a slider bar? or fixed input (e.g. range from 15/30/45/60/120/240 mins to 15/30/45/60/120/240 mins)

Yup the routes file is indeed very long. In future PRs we can split the routes into multiple files along with helpers.

As for the filtering like the slider bar, what I had in mind was to reduce typing on keyboard and mostly just use the mouse for the user.

@Ryuse Ryuse merged commit 6f9e889 into CS3219-AY2526Sem1:master Oct 15, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants