-
Notifications
You must be signed in to change notification settings - Fork 4
Feat: Admin Question Management #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Admin Question Management #39
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Currently the question-backend/routes.ts
might seems a little long with 600 LOC due to the added API - we can consider looking into refactoring the code in another PR for better maintainability.
Might be able to improve on the UI side for the Admin Question but the current version works for now!
Another consideration is the design of UI for time limit --> do we want a slider bar? or fixed input (e.g. range from 15/30/45/60/120/240 mins to 15/30/45/60/120/240 mins). If we are sticking to the slider bar, we might want to consider increasing the slider button for easier sliding.
Yup the routes file is indeed very long. In future PRs we can split the routes into multiple files along with helpers. As for the filtering like the slider bar, what I had in mind was to reduce typing on keyboard and mostly just use the mouse for the user. |
For admins to see questions available on the question service.
Current features:
https://github.com/user-attachments/assets/d062982e-3e2a-4930-ac06-301949d07860