-
Notifications
You must be signed in to change notification settings - Fork 0
Cam 461/wse vs reach for timeseries view #98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
…de profile charts, added check to make sure charts are not undefined when attempting to update them.
devincowan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great @Castronova! Nice!
Two things need to be fixed before we can merge:
- Please resolve conflicts with Develop (I checked, doesn't look like this should be too bad)
- There is a bug when you change the DQ settings after plotting the WSE/WIDTH
wse-vs-width.mov
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't look at the code yet, but I see that you resolved the DataQuality bug that I noted on first review 👏
But I see that if I access this plot using a shared link, for example:
https://cuahsi.github.io/SWOT-Data-Viewer/#/plots/62222100021?variables=wse/width
then the plot is pretty funkified:

UPDATE: oh interesting, it looks like it is maybe because
https://cuahsi.github.io/SWOT-Data-Viewer/#/plots/62222100021?variables=wse/width
redirects to:
https://cuahsi.github.io/SWOT-Data-Viewer/#/plots/62222100021?variables=wse/time
cd7ba11 to
704d0cf
Compare
704d0cf to
3135b83
Compare
3135b83 to
923dbed
Compare
|
I took a look at this PR again today. Appears it still has the same issue that I mentioned back in December Here is a video showing the problem |
|
I tried resolving conflicts against develop for this PR and was not successful. |
Changes: