Skip to content

security: fix SQLi, XSS, credential exposure, and insecure deserialization #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
somethingwithproof wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

security: fix SQLi, XSS, credential exposure, and insecure deserialization #322

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/mactrack_functions.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3360,7 +3360,7 @@ function mactrack_create_sql_filter($filter, $fields) {
$query .= '(';
}

$query .= ($field_no == 1 ? '' : " $operator ") . "($field $type LIKE '%" . $filter . "%')";
$query .= ($field_no == 1 ? '' : " $operator ") . "($field $type LIKE " . db_qstr('%' . $filter . '%') . ")";

$field_no++;
}
Expand Down Expand Up @@ -3582,7 +3582,7 @@ function mactrack_site_filter($page = 'mactrack_sites.php') {
<?php print __('Search', 'mactrack'); ?>
</td>
<td>
<input type='text' id='filter' size='25' value='<?php print get_request_var('filter'); ?>'>
<input type='text' id='filter' size='25' value='<?php print html_escape_request_var('filter'); ?>'>
</td>
<td>
<?php print __('Sites', 'mactrack'); ?>
Expand Down
25 changes: 12 additions & 13 deletions mactrack_device_types.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -749,7 +749,6 @@ function mactrack_device_type_import_processor(&$device_types) {

foreach ($line_array as $line_item) {
if (in_array($j, $insert_columns, true)) {
$line_item = trim(str_replace("'", '', $line_item));
$line_item = trim(str_replace('"', '', $line_item));
Copy link

Copilot AI Mar 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as the device import: this CSV import logic strips all double quotes from fields and depends on a simplistic comma split earlier, which will corrupt valid CSV containing quoted fields, embedded commas, or escaped quotes. Consider using a proper CSV parser (str_getcsv()/fgetcsv()) and removing the blanket quote stripping so imports are correct and predictable.

Suggested change
$line_item = trim(str_replace('"', '', $line_item));
$line_item = trim($line_item);

Copilot uses AI. Check for mistakes.

if (!$first_column) {
Expand All @@ -762,15 +761,15 @@ function mactrack_device_type_import_processor(&$device_types) {
if ($sql_where != '') {
switch($j) {
case $device_type_id:
$sql_where .= " AND device_type='$line_item'";
$sql_where .= ' AND device_type=' . db_qstr($line_item);

break;
case $sysDescr_match_id:
$sql_where .= " AND sysDescr_match='$line_item'";
$sql_where .= ' AND sysDescr_match=' . db_qstr($line_item);

break;
case $sysObjectID_match_id:
$sql_where .= " AND sysObjectID_match='$line_item'";
$sql_where .= ' AND sysObjectID_match=' . db_qstr($line_item);

break;
default:
Expand All @@ -779,15 +778,15 @@ function mactrack_device_type_import_processor(&$device_types) {
} else {
switch($j) {
case $device_type_id:
$sql_where .= "WHERE device_type='$line_item'";
$sql_where .= 'WHERE device_type=' . db_qstr($line_item);

break;
case $sysDescr_match_id:
$sql_where .= "WHERE sysDescr_match='$line_item'";
$sql_where .= 'WHERE sysDescr_match=' . db_qstr($line_item);

break;
case $sysObjectID_match_id:
$sql_where .= "WHERE sysObjectID_match='$line_item'";
$sql_where .= 'WHERE sysObjectID_match=' . db_qstr($line_item);

break;
default:
Expand Down Expand Up @@ -821,7 +820,7 @@ function mactrack_device_type_import_processor(&$device_types) {
$description = $line_item;
}

$save_value .= "'" . $line_item . "'";
$save_value .= db_qstr($line_item);
}

$j++;
Expand Down Expand Up @@ -901,10 +900,10 @@ function mactrack_device_type_edit() {

function mactrack_get_device_types(&$sql_where, $rows, $apply_limits = true) {
if (get_request_var('filter') != '') {
$sql_where = " WHERE (mtdt.vendor LIKE '%" . get_request_var('filter') . "%' OR
mtdt.description LIKE '%" . get_request_var('filter') . "%' OR
mtdt.sysDescr_match LIKE '%" . get_request_var('filter') . "%' OR
mtdt.sysObjectID_match LIKE '%" . get_request_var('filter') . "%')";
$sql_where = " WHERE (mtdt.vendor LIKE " . db_qstr('%' . get_request_var('filter') . '%') . " OR
mtdt.description LIKE " . db_qstr('%' . get_request_var('filter') . '%') . " OR
mtdt.sysDescr_match LIKE " . db_qstr('%' . get_request_var('filter') . '%') . " OR
mtdt.sysObjectID_match LIKE " . db_qstr('%' . get_request_var('filter') . '%') . ")";
}

if (get_request_var('vendor') == 'All') {
Expand Down Expand Up @@ -1053,7 +1052,7 @@ function mactrack_device_type_filter() {
<?php print __('Search', 'mactrack'); ?>
</td>
<td>
<input type='text' id='filter' size='25' value='<?php print get_request_var('filter'); ?>'>
<input type='text' id='filter' size='25' value='<?php print html_escape_request_var('filter'); ?>'>
</td>
<td>
<?php print __('Device Types', 'mactrack'); ?>
Expand Down
31 changes: 15 additions & 16 deletions mactrack_devices.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -746,7 +746,6 @@ function mactrack_device_import_processor(&$devices) {
if (cacti_sizeof($line_array)) {
foreach ($line_array as $line_item) {
if (in_array($j, $insert_columns, true)) {
$line_item = trim(str_replace("'", '', $line_item));
$line_item = trim(str_replace('"', '', $line_item));

if (!$first_column) {
Expand All @@ -759,15 +758,15 @@ function mactrack_device_import_processor(&$devices) {
if ($sql_where != '') {
switch($j) {
case $save_site_id_id:
$sql_where .= " AND site_id='$line_item'";
$sql_where .= ' AND site_id=' . db_qstr($line_item);

break;
case $save_snmp_port_id:
$sql_where .= " AND snmp_port='$line_item'";
$sql_where .= ' AND snmp_port=' . db_qstr($line_item);

break;
case $save_host_id:
$sql_where .= " AND hostname='$line_item'";
$sql_where .= ' AND hostname=' . db_qstr($line_item);

break;
default:
Expand All @@ -776,15 +775,15 @@ function mactrack_device_import_processor(&$devices) {
} else {
switch($j) {
case $save_site_id_id:
$sql_where .= "WHERE site_id='$line_item'";
$sql_where .= 'WHERE site_id=' . db_qstr($line_item);

break;
case $save_snmp_port_id:
$sql_where .= "WHERE snmp_port='$line_item'";
$sql_where .= 'WHERE snmp_port=' . db_qstr($line_item);

break;
case $save_host_id:
$sql_where .= "WHERE hostname='$line_item'";
$sql_where .= 'WHERE hostname=' . db_qstr($line_item);

break;
default:
Expand All @@ -809,7 +808,7 @@ function mactrack_device_import_processor(&$devices) {
$device_name = $line_item;
}

$save_value .= "'" . $line_item . "'";
$save_value .= db_qstr($line_item);
}

$j++;
Expand Down Expand Up @@ -935,10 +934,10 @@ function mactrack_device_edit() {
$snmp_objid = str_replace('OID: ', '', $snmp_objid);
$snmp_objid = str_replace('.iso', '.1', $snmp_objid);

print '<strong>' . __('System:', 'mactrack') . "</strong> $snmp_system<br>\n";
print '<strong>' . __('Uptime:', 'mactrack') . "</strong> $snmp_uptime<br>\n";
print '<strong>' . __('Hostname:', 'mactrack') . "</strong> $snmp_hostname<br>\n";
print '<strong>' . __('ObjectID:', 'mactrack') . "</strong> $snmp_objid<br>\n";
print '<strong>' . __('System:', 'mactrack') . '</strong> ' . html_escape($snmp_system) . "<br>\n";
print '<strong>' . __('Uptime:', 'mactrack') . '</strong> ' . html_escape($snmp_uptime) . "<br>\n";
print '<strong>' . __('Hostname:', 'mactrack') . '</strong> ' . html_escape($snmp_hostname) . "<br>\n";
print '<strong>' . __('ObjectID:', 'mactrack') . '</strong> ' . html_escape($snmp_objid) . "<br>\n";
}
?>
</span>
Expand Down Expand Up @@ -973,9 +972,9 @@ function mactrack_device_edit() {
function mactrack_get_devices(&$sql_where, $rows, $apply_limits = true) {
// form the 'where' clause for our main sql query
if (get_request_var('filter') != '') {
$sql_where = ($sql_where != '' ? ' AND ' : 'WHERE ') . "(mtd.hostname like '%" . get_request_var('filter') . "%'
OR mtd.device_name like '%" . get_request_var('filter') . "%'
OR mtd.notes like '%" . get_request_var('filter') . "%')";
$sql_where = ($sql_where != '' ? ' AND ' : 'WHERE ') . "(mtd.hostname LIKE " . db_qstr('%' . get_request_var('filter') . '%') . "
OR mtd.device_name LIKE " . db_qstr('%' . get_request_var('filter') . '%') . "
OR mtd.notes LIKE " . db_qstr('%' . get_request_var('filter') . '%') . ")";
Comment on lines +975 to +977
Copy link

Copilot AI Mar 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The filter SQL in mactrack_get_devices() is assembled using a multi-line string literal that spans lines 975–977. While it works, it’s much harder to read and differs from the pattern used elsewhere in the plugin (explicit concatenation with " OR "). Consider rewriting this as a single-line concatenation (or building an array of clauses and implode(' OR ', ...)) to avoid accidental quoting/whitespace mistakes in future edits.

Suggested change
$sql_where = ($sql_where != '' ? ' AND ' : 'WHERE ') . "(mtd.hostname LIKE " . db_qstr('%' . get_request_var('filter') . '%') . "
OR mtd.device_name LIKE " . db_qstr('%' . get_request_var('filter') . '%') . "
OR mtd.notes LIKE " . db_qstr('%' . get_request_var('filter') . '%') . ")";
$filter = db_qstr('%' . get_request_var('filter') . '%');
$sql_where = ($sql_where != '' ? ' AND ' : 'WHERE ') .
'(mtd.hostname LIKE ' . $filter .
' OR mtd.device_name LIKE ' . $filter .
' OR mtd.notes LIKE ' . $filter . ')';

Copilot uses AI. Check for mistakes.
}

if (get_request_var('status') == '-1') {
Expand Down Expand Up @@ -1160,7 +1159,7 @@ function mactrack_device_filter() {
<?php print __('Search', 'mactrack'); ?>
</td>
<td>
<input type='text' id='filter' size='25' value='<?php print get_request_var('filter'); ?>'>
<input type='text' id='filter' size='25' value='<?php print html_escape_request_var('filter'); ?>'>
</td>
<td>
<?php print __('Site', 'mactrack'); ?>
Expand Down
6 changes: 3 additions & 3 deletions mactrack_macauth.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,8 +219,8 @@ function mactrack_maca_get_maca_records(&$sql_where, $rows, $apply_limits = true
$sql_where = '';

if (get_request_var('filter') != '') {
$sql_where = "WHERE (mac_address LIKE '%" . str_replace(['-', '.', ':'],'',get_request_var('filter')) . "%' OR " .
"description LIKE '%" . get_request_var('filter') . "%')";
$sql_where = "WHERE (mac_address LIKE " . db_qstr('%' . str_replace(['-', '.', ':'],'',get_request_var('filter')) . '%') . " OR " .
"description LIKE " . db_qstr('%' . get_request_var('filter') . '%') . ")";
}

$sql_order = get_order_string();
Expand Down Expand Up @@ -384,7 +384,7 @@ function mactrack_maca_filter() {
<?php print __('Search', 'mactrack'); ?>
</td>
<td>
<input type='text' id='filter' size='25' value='<?php print get_request_var('filter'); ?>'>
<input type='text' id='filter' size='25' value='<?php print html_escape_request_var('filter'); ?>'>
</td>
<td>
<?php print __('MAC\'s', 'mactrack'); ?>
Expand Down
10 changes: 5 additions & 5 deletions mactrack_macwatch.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,10 +203,10 @@ function mactrack_macw_get_macw_records(&$sql_where, $rows, $apply_limits = true

// form the 'where' clause for our main sql query
if (get_request_var('filter') != '') {
$sql_where = "WHERE (mac_address LIKE '%" . get_request_var('filter') . "%' OR " .
"name LIKE '%" . get_request_var('filter') . "%' OR " .
"ticket_number LIKE '%" . get_request_var('filter') . "%' OR " .
"description LIKE '%" . get_request_var('filter') . "%')";
$sql_where = "WHERE (mac_address LIKE " . db_qstr('%' . get_request_var('filter') . '%') . " OR " .
"name LIKE " . db_qstr('%' . get_request_var('filter') . '%') . " OR " .
"ticket_number LIKE " . db_qstr('%' . get_request_var('filter') . '%') . " OR " .
"description LIKE " . db_qstr('%' . get_request_var('filter') . '%') . ")";
}

$sql_order = get_order_string();
Expand Down Expand Up @@ -392,7 +392,7 @@ function mactrack_macw_filter() {
<?php print __('Search', 'mactrack'); ?>
</td>
<td>
<input type='text' id='filter' size='25' value='<?php print get_request_var('filter'); ?>'>
<input type='text' id='filter' size='25' value='<?php print html_escape_request_var('filter'); ?>'>
</td>
<td>
<?php print __('Watches', 'mactrack'); ?>
Expand Down
8 changes: 4 additions & 4 deletions mactrack_sites.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,11 +291,11 @@ function mactrack_site_get_site_records(&$sql_where, $rows, $apply_limits = true
// form the 'where' clause for our main sql query
if (get_request_var('filter') != '') {
if (get_request_var('detail') == 'false') {
$sql_where = "WHERE (mts.site_name LIKE '%" . get_request_var('filter') . "%')";
$sql_where = "WHERE (mts.site_name LIKE " . db_qstr('%' . get_request_var('filter') . '%') . ")";
} else {
$sql_where = "WHERE (mts.vendor LIKE '%" . get_request_var('filter') . "%' OR " .
"mtdt.description LIKE '%" . get_request_var('filter') . "%' OR " .
"mts.site_name LIKE '%" . get_request_var('filter') . "%')";
$sql_where = "WHERE (mts.vendor LIKE " . db_qstr('%' . get_request_var('filter') . '%') . " OR " .
"mtdt.description LIKE " . db_qstr('%' . get_request_var('filter') . '%') . " OR " .
"mts.site_name LIKE " . db_qstr('%' . get_request_var('filter') . '%') . ")";
}
}

Expand Down
4 changes: 2 additions & 2 deletions mactrack_snmp.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -541,7 +541,7 @@ function mactrack_snmp() {
$sql_where = '';

if (get_request_var('filter') != '') {
$sql_where .= "WHERE (mac_track_snmp.name LIKE '%" . get_request_var('filter') . "%')";
$sql_where .= "WHERE (mac_track_snmp.name LIKE " . db_qstr('%' . get_request_var('filter') . '%') . ")";
}

$total_rows = db_fetch_cell("SELECT
Expand Down Expand Up @@ -607,7 +607,7 @@ function snmp_options_filter() {
<?php print __('Search', 'mactrack'); ?>
</td>
<td>
<input type='text' id='filter' size='25' value='<?php print get_request_var('filter'); ?>'>
<input type='text' id='filter' size='25' value='<?php print html_escape_request_var('filter'); ?>'>
</td>
<td>
<?php print __('Options', 'mactrack'); ?>
Expand Down
8 changes: 4 additions & 4 deletions mactrack_vendormacs.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,9 +103,9 @@ function mactrack_vmacs_get_vmac_records(&$sql_where, $rows, $apply_limits = tru

// form the 'where' clause for our main sql query
if (get_request_var('filter') != '') {
$sql_where = "WHERE (mac_track_oui_database.vendor_name LIKE '%" . get_request_var('filter') . "%' OR " .
"mac_track_oui_database.vendor_mac LIKE '%" . get_request_var('filter') . "%' OR " .
"mac_track_oui_database.vendor_address LIKE '%" . get_request_var('filter') . "%')";
$sql_where = "WHERE (mac_track_oui_database.vendor_name LIKE " . db_qstr('%' . get_request_var('filter') . '%') . " OR " .
"mac_track_oui_database.vendor_mac LIKE " . db_qstr('%' . get_request_var('filter') . '%') . " OR " .
"mac_track_oui_database.vendor_address LIKE " . db_qstr('%' . get_request_var('filter') . '%') . ")";
}

$sql_order = get_order_string();
Expand Down Expand Up @@ -201,7 +201,7 @@ function mactrack_vmac_filter() {
<?php print __('Search', 'mactrack'); ?>
</td>
<td>
<input type='text' id='filter' size='25' value='<?php print get_request_var('filter'); ?>'>
<input type='text' id='filter' size='25' value='<?php print html_escape_request_var('filter'); ?>'>
</td>
<td>
<?php print __('MAC\'s', 'mactrack'); ?>
Expand Down
2 changes: 1 addition & 1 deletion mactrack_view_arp.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -453,7 +453,7 @@ function mactrack_ip_address_filter() {
<?php print __('Search', 'mactrack'); ?>
</td>
<td>
<input type='text' id='filter' size='25' value='<?php print get_request_var('filter'); ?>'>
<input type='text' id='filter' size='25' value='<?php print html_escape_request_var('filter'); ?>'>
</td>
<td>
<?php print __('Site', 'mactrack'); ?>
Expand Down
20 changes: 7 additions & 13 deletions mactrack_view_devices.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,9 +105,7 @@ function mactrack_view_export_devices() {

$xport_array = [];
array_push($xport_array, 'site_id, site_name, device_id, device_name, notes, ' .
'hostname, snmp_readstring, snmp_readstrings, snmp_version, ' .
'snmp_username, snmp_password, snmp_auth_protocol, snmp_priv_passphrase, ' .
'snmp_priv_protocol, snmp_context, snmp_engine_id, ' .
'hostname, snmp_version, ' .
'snmp_port, snmp_timeout, snmp_retries, max_oids, snmp_sysName, snmp_sysLocation, ' .
'snmp_sysContact, snmp_sysObjectID, snmp_sysDescr, snmp_sysUptime, ' .
'ignorePorts, scan_type, disabled, ports_total, ports_active, ' .
Expand All @@ -119,11 +117,7 @@ function mactrack_view_export_devices() {
$device['site_id'] . '","' . $device['site_name'] . '","' .
$device['device_id'] . '","' . $device['device_name'] . '","' .
$device['notes'] . '","' . $device['hostname'] . '","' .
$device['snmp_readstring'] . '","' . $device['snmp_readstrings'] . '","' .
$device['snmp_version'] . '","' . $device['snmp_username'] . '","' .
$device['snmp_password'] . '","' . $device['snmp_auth_protocol'] . '","' .
$device['snmp_priv_passphrase'] . '","' . $device['snmp_priv_protocol'] . '","' .
$device['snmp_context'] . '","' . $device['snmp_engine_id'] . '","' .
$device['snmp_version'] . '","' .
$device['snmp_port'] . '","' . $device['snmp_timeout'] . '","' .
$device['snmp_retries'] . '","' . $device['max_oids'] . '","' .
$device['snmp_sysName'] . '","' . $device['snmp_sysLocation'] . '","' .
Expand Down Expand Up @@ -161,10 +155,10 @@ function mactrack_view_get_device_records(&$sql_where, $rows, $apply_limits = tr

// form the 'where' clause for our main sql query
if (get_request_var('filter') != '') {
$sql_where .= ($sql_where != '' ? ' AND ' : 'WHERE ') . "(mac_track_devices.hostname LIKE '%" . get_request_var('filter') . "%' OR " .
"mac_track_devices.notes LIKE '%" . get_request_var('filter') . "%' OR " .
"mac_track_devices.device_name LIKE '%" . get_request_var('filter') . "%' OR " .
"mac_track_sites.site_name LIKE '%" . get_request_var('filter') . "%')";
$sql_where .= ($sql_where != '' ? ' AND ' : 'WHERE ') . "(mac_track_devices.hostname LIKE " . db_qstr('%' . get_request_var('filter') . '%') . " OR " .
"mac_track_devices.notes LIKE " . db_qstr('%' . get_request_var('filter') . '%') . " OR " .
"mac_track_devices.device_name LIKE " . db_qstr('%' . get_request_var('filter') . '%') . " OR " .
"mac_track_sites.site_name LIKE " . db_qstr('%' . get_request_var('filter') . '%') . ")";
}

if (cacti_sizeof($device_type_info)) {
Expand Down Expand Up @@ -427,7 +421,7 @@ function mactrack_device_filter2() {
<?php print __('Search', 'mactrack'); ?>
</td>
<td>
<input type='text' id='filter' size='25' value='<?php print get_request_var('filter'); ?>'>
<input type='text' id='filter' size='25' value='<?php print html_escape_request_var('filter'); ?>'>
</td>
<td>
<?php print __('Site', 'mactrack'); ?>
Expand Down
2 changes: 1 addition & 1 deletion mactrack_view_interfaces.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -648,7 +648,7 @@ function mactrack_filter_table() {
<?php print __('Search', 'mactrack'); ?>
</td>
<td>
<input type='text' id='filter' size='25' value='<?php print get_request_var('filter'); ?>'>
<input type='text' id='filter' size='25' value='<?php print html_escape_request_var('filter'); ?>'>
</td>
<td>
<input type='checkbox' id='totals' onChange='applyFilter()' <?php print(get_request_var('totals') == 'true' ? 'checked' : ''); ?>>
Expand Down
9 changes: 7 additions & 2 deletions mactrack_view_macs.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,12 @@ function form_actions() {

// if we are to save this form, instead of display it
if (isset_request_var('selected_items')) {
$selected_items = unserialize(get_nfilter_request_var('selected_items'));
$selected_items = cacti_unserialize(stripslashes(get_nfilter_request_var('selected_items')));

if (!is_array($selected_items)) {
header('Location: mactrack_view_macs.php');
exit;
}

Comment on lines +91 to 97
Copy link

Copilot AI Mar 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This action handler now uses cacti_unserialize() directly, but the same file also uses sanitize_unserialize_selected_items() for other actions. Using two different unserialize/validation paths for selected_items makes behavior inconsistent and increases the chance of missing validation in one path. Consider routing this through the same helper (or otherwise centralizing the validation) so all bulk-action entry points enforce the same rules.

Suggested change
$selected_items = cacti_unserialize(stripslashes(get_nfilter_request_var('selected_items')));
if (!is_array($selected_items)) {
header('Location: mactrack_view_macs.php');
exit;
}
$selected_items = sanitize_unserialize_selected_items();

Copilot uses AI. Check for mistakes.
foreach ($selected_items as $mac=>$ip) {
if (!filter_var($mac, FILTER_VALIDATE_MAC)) {
Expand Down Expand Up @@ -1106,7 +1111,7 @@ function mactrack_mac_filter() {
<?php print __('Search', 'mactrack'); ?>
</td>
<td>
<input type='text' id='filter' size='25' value='<?php print get_request_var('filter'); ?>'>
<input type='text' id='filter' size='25' value='<?php print html_escape_request_var('filter'); ?>'>
</td>
<td>
<?php print __('Site', 'mactrack'); ?>
Expand Down
8 changes: 4 additions & 4 deletions mactrack_view_sites.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,11 +93,11 @@ function mactrack_view_get_site_records(&$sql_where, $rows, $apply_limits = true
// form the 'where' clause for our main sql query
if (get_request_var('filter') != '') {
if (get_request_var('detail') == 'false') {
$sql_where = "WHERE (mac_track_sites.site_name LIKE '%" . get_request_var('filter') . "%')";
$sql_where = "WHERE (mac_track_sites.site_name LIKE " . db_qstr('%' . get_request_var('filter') . '%') . ")";
} else {
$sql_where = "WHERE (mac_track_device_types.vendor LIKE '%" . get_request_var('filter') . "%' OR " .
"mac_track_device_types.description LIKE '%" . get_request_var('filter') . "%' OR " .
"mac_track_sites.site_name LIKE '%" . get_request_var('filter') . "%')";
$sql_where = "WHERE (mac_track_device_types.vendor LIKE " . db_qstr('%' . get_request_var('filter') . '%') . " OR " .
"mac_track_device_types.description LIKE " . db_qstr('%' . get_request_var('filter') . '%') . " OR " .
"mac_track_sites.site_name LIKE " . db_qstr('%' . get_request_var('filter') . '%') . ")";
}
}

Expand Down
Loading