[ENG-8524] Update permissions for write preprint contributors #11272
+11
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@Vlad0n20 Could you rebase this onto the latest |
Vlad0n20
force-pushed
the
fix/ENG-8524
branch
from
e333421 to
9e6f8fd
Compare
antkryt
suggested changes
Nov 21, 2025
api/actions/permissions.py
Outdated
| try: | ||
| serializer = view.get_serializer(data=request.data) | ||
| serializer.is_valid(raise_exception=True) | ||
| trigger = serializer.validated_data.get('trigger') |
Contributor
There was a problem hiding this comment.
you already have
serializer = view.get_serializer(data=request.data)
serializer.is_valid(raise_exception=True)
trigger = serializer.validated_data.get('trigger')
below, no need to call it again here
api/actions/permissions.py
Outdated
| # User can trigger state changes on this reviewable, but can they use this trigger in particular? | ||
| serializer = view.get_serializer(data=request.data) | ||
| serializer.is_valid(raise_exception=True) | ||
| trigger = serializer.validated_data.get('trigger') |
Contributor
|
LGTM |
Vlad0n20
changed the base branch from
feature/pbs-25-21
to
feature/pbs-25-25
Vlad0n20
force-pushed
the
fix/ENG-8524
branch
from
ddf32f2 to
b87ceb7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Changes
QA Notes
Please make verification statements inspired by your code and what your code touches.
What are the areas of risk?
Any concerns/considerations/questions that development raised?
Documentation
Side Effects
Ticket
https://openscience.atlassian.net/browse/ENG-8524?atlOrigin=eyJpIjoiY2QyMDBlZDRmMGE2NGExNjg1Y2NkZjMyZTc2MDA3NTYiLCJwIjoiaiJ9