refactor(BillboardCollection): Require instancing, remove batch mode #13049
+134
−376
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For discussion. Removes fallback code paths from BillboardCollection.js and related code, for cases where
ANGLE_instanced_arraysis not available. Support for instancing at 99.99% globally according, and required in WebGL 2:https://web3dsurvey.com/webgl/extensions/ANGLE_instanced_arrays
That said... there might be reasons to keep the fallback that aren't captured in these stats? It would be a nice simplification in billboard code if possible, and avoids further changes being required in #13050.
Issue number and link
Testing plan
TBD
Author checklist
CONTRIBUTORS.mdCHANGES.mdwith a short summary of my changePR Dependency Tree
This tree was auto-generated by Charcoal