Skip to content

Conversation

@jfayot
Copy link

@jfayot jfayot commented Mar 5, 2025

This PR tries to address Dependency management issues between Cesium and gltf-pipeline.

The first part (this PR) is to detach a @gltf-pipeline/core library that has no dependency on node.
The next steps, will be to detach a @cesium/core component that will be importable into gltf-pipeline

Proposed dependency graph:

graph TD;
    gb[["`**bin**: gltf-pipeline`"]]
    gl[@gltf-pipeline/lib]
    gp[["`**lib**: gltf-pipeline`"]]
    gc[@gltf-pipeline/core]
    c[[cesium]]
    ce[@cesium/engine]
    cc[@cesium/core]
    cw[@cesium/widgets]

    c-->ce;
    c-->cw;
    ce-->gc;
    ce-->cc;
    cw-->ce;
    cw-->cc;
    gb-->gl;
    gp-->gl;
    gp-->gc;
    gc-->cc;
Loading

@jfayot jfayot changed the title First move towards propper dependency management First move towards better dependency management Mar 5, 2025
@ggetz
Copy link
Contributor

ggetz commented Mar 5, 2025

@ankittrehan2000 Could you or someone from the ion squad let us know:

  • If you or the tilers still depend on this
  • If yes, what's the plan going forward? Are there any short or long term plans to move away from it?

That will help give us context to decide how we move forward with this on CesiumJS.

@ankittrehan2000
Copy link
Contributor

ankittrehan2000 commented Mar 6, 2025

If you or the tilers still depend on this

Our old tilers (swayze) use this in multiple places. ion-tiling and ion don't use it currently

If yes, what's the plan going forward? Are there any short or long term plans to move away from it?

I don't think there are any plans to move away from this library but someone from tilers is probably the best to answer that. @keyboardspecialist perhaps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants