-
Notifications
You must be signed in to change notification settings - Fork 1
feat(build): use blst packaged for zig using zig build system
#51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Packaged `blst` for use by zig projects in this [repo](https://github.com/chainsafe/blst.zig), inspired by projects in [allyourcodebase](https://github.com/allyourcodebase). This also decouples managing `blst` options into that that repo's `build.zig`.
51af405 to
bd52509
Compare
spiral-ladder
commented
Sep 26, 2025
| with: | ||
| name: ${{ matrix.settings.bun-target }} | ||
| path: 'zig-out/lib/*blst_min_pk.*' | ||
| path: 'zig-out/lib/*eth_blst.*' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had to update this name to match the output in build.zig.
|
note that I also removed building |
Performance Report✔️ no performance regression detected Full benchmark results
|
wemeetagain
approved these changes
Sep 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packaged
blstfor use by zig projects in thisrepo, inspired by projects in allyourcodebase.
This also decouples managing
blstoptions into that that repo'sbuild.zig.