Added handleFacebookMessage#96
Open
shubhadit wants to merge 1 commit intoCharca:masterfrom
shubhadit:patch-2
Open
Added handleFacebookMessage#96shubhadit wants to merge 1 commit intoCharca:masterfrom shubhadit:patch-2
shubhadit wants to merge 1 commit intoCharca:masterfrom
shubhadit:patch-2
Conversation
Collaborator
|
Collaborator
|
I'm really busy ATM so I might not have time until the beginning of next week. |
mraaroncruz
reviewed
Dec 15, 2017
| } else { | ||
| console.log('Webhook received unknown event: ', event); | ||
| } | ||
| this.handleFacebookMessage(event); |
Collaborator
There was a problem hiding this comment.
handleFacebookEntry()? Fits facebooks API better and maybe easier to translate for people who actually know what their data looks like (the assumed clients of this method).
Owner
|
@mraaroncruz can we close this PR now? It looks like |
Owner
|
Oh, I see this is to handle each individual event, nevermind. This looks good to me, but I'd like to see some of the changes you mentioned above, specially:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.