Skip to content

Conversation

@arvidn
Copy link
Contributor

@arvidn arvidn commented Oct 14, 2025

Purpose:

Make sure we only allow a pool contract puzzle hash for v2 proofs-of-space. Not a pool public key.

Current Behavior:

We don't require PoS 2 to only have pool contract puzzle hash, but also allow a pool public key.

New Behavior:

We require PoS 2 to only have pool contract puzzle hash, disallowing a pool public key.

@arvidn arvidn requested a review from a team as a code owner October 14, 2025 14:51
@arvidn arvidn requested a review from almogdepaz October 14, 2025 18:33
@arvidn arvidn added the Changed Required label for PR that categorizes merge commit message as "Changed" for changelog label Oct 14, 2025
@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Oct 22, 2025
@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Nov 20, 2025
@github-actions
Copy link
Contributor

File Coverage Missing Lines
chia/consensus/block_header_validation.py 50.0% lines 775
Total Missing Coverage
11 lines Unknown 90%

@arvidn arvidn requested a review from wjblanke November 21, 2025 09:28
Copy link
Contributor

@wjblanke wjblanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aok

@TheLastCicada TheLastCicada merged commit b772325 into main Nov 21, 2025
402 of 405 checks passed
@TheLastCicada TheLastCicada deleted the pos2-pool-ph branch November 21, 2025 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Changed Required label for PR that categorizes merge commit message as "Changed" for changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants