make timelord/test_new_peak.py a bit more robust

[arvidn]

Purpose:

This test is ensuring unfinished blocks ended up accepted by the timelord. However, the timelord sometimes record unfinished blocks in the overflows list.

This makes the test pick either of the lists, and therefore makes it more robust as we add new test chains. We'll add additional test chains for the 3.0 hard fork.

[coveralls-official]

Pull Request Test Coverage Report for Build 19477990032

Details

• 10 of 11 (90.91%) changed or added relevant lines in 2 files are covered.
• 23 unchanged lines in 7 files lost coverage.
• Overall coverage increased (+0.02%) to 90.785%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
chia/_tests/timelord/test_new_peak.py	8	9	88.89%

Files with Coverage Reduction	New Missed Lines	%
chia/wallet/util/wallet_sync_utils.py	1	85.57%
chia/data_layer/data_layer.py	2	86.22%
chia/_tests/core/test_farmer_harvester_rpc.py	2	98.06%
chia/timelord/timelord.py	3	71.68%
chia/wallet/wallet_node.py	3	86.61%
chia/introducer/introducer.py	5	81.9%
chia/daemon/server.py	7	80.62%

Totals
Change from base Build 19476368417:	0.02%
Covered Lines:	102541
Relevant Lines:	112775

---

💛 - Coveralls

[almogdepaz]

so this was failing whenever the blocks turned out to be overflow ?

i think it would be better to check if the block is overflow or not and check the relevant list

[arvidn]

so this was failing whenever the blocks turned out to be overflow ?

Yes. I suspect that with the new chains I generated, some of these blocks happened to be overflow blocks, by chance.

[github-actions]

File	Coverage	Missing Lines
chia/_tests/timelord/test_new_peak.py	93.3%	lines 25

Total	Missing	Coverage
17 lines	Unknown	94%

[wjblanke]

aok