-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Test conditions pool reward #20288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Test conditions pool reward #20288
+19
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 19575112224Details
💛 - Coveralls |
61a855a to
63cd893
Compare
…d, for its tests. This prepares this test to work with v2 plots, since they don't support redirecting the pool reward
63cd893 to
11a2cde
Compare
almogdepaz
approved these changes
Nov 23, 2025
wjblanke
approved these changes
Nov 25, 2025
Contributor
wjblanke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aok
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Changed
Required label for PR that categorizes merge commit message as "Changed" for changelog
ready_to_merge
Submitter and reviewers think this is ready
Tests
Changes to tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose:
This is a follow-up to #20277
Reducing more use of the
pool_reward_puzzle_hashfeature inBlockTools. This isn't supported for v2 plots.The current test picks the first reward coin, which happens to be the pool reward. Changing this coin to the farmer reward has some consequences. First of all, we need to use
find_reward_coin()to pick the coin with the puzzle hash we expect, instead of just picking the first one.The cost of spending the pool reward is 1 byte higher than the farmer reward. This is because the pool reward is 1'750'000'000, whereas the farmer reward is only 25'000'000.
It requires one byte less to be encoded. The cost of bytes in the generator is 12000 per byte. There are two tests that check the cost of the puzzle, whose cost is now 12000 less.
Current Behavior:
The
initial_blocks()function redirects both farmer rewards and pool rewards into the test wallet.New Behavior:
The
initial_blocks()function only redirects farmer rewards into the test wallet. Thus making the test compatible with v2 plots.