Skip to content

Conversation

@arvidn
Copy link
Contributor

@arvidn arvidn commented Nov 26, 2025

Purpose:

When validating proofs of space in weight proofs, we don't necessarily know the height of the block, or the previous transaction block height.

This information is technically required to validate the proof-of-space. The reason for this is that the 3.0 hard fork will introduce a phase-out schedule for v1 plots, where the validity of a v1 proof depends on how far long the phase-out we've come.

Since we don't know the height, this patch relaxes the validation to not apply the phase-out to v1 plots.

We also use the height to determine the plot filter schedule. However, both the v1 and v2 plot filters relax over time, so using the peak block height will already use the most relaxed plot filter for the lower heights.

Current Behavior:

  • We don't support the v1 phase-out in weight proofs

New Behavior:

  • we do support the v1 phase-out, by not applying it to weight proofs

@arvidn arvidn requested a review from almogdepaz November 26, 2025 09:37
@arvidn arvidn added the Changed Required label for PR that categorizes merge commit message as "Changed" for changelog label Nov 26, 2025
@arvidn arvidn marked this pull request as ready for review November 26, 2025 10:20
@arvidn arvidn requested a review from a team as a code owner November 26, 2025 10:20
@github-actions
Copy link
Contributor

File Coverage Missing Lines
chia/types/blockchain_format/proof_of_space.py 75.0% lines 140-141
Total Missing Coverage
8 lines 2 lines 75%

@coveralls-official
Copy link

Pull Request Test Coverage Report for Build 19700259327

Details

  • 6 of 8 (75.0%) changed or added relevant lines in 1 file are covered.
  • 25 unchanged lines in 6 files lost coverage.
  • Overall coverage increased (+0.2%) to 90.915%

Changes Missing Coverage Covered Lines Changed/Added Lines %
chia/types/blockchain_format/proof_of_space.py 6 8 75.0%
Files with Coverage Reduction New Missed Lines %
chia/full_node/full_node_rpc_api.py 1 79.22%
chia/full_node/full_node.py 3 87.01%
chia/timelord/timelord.py 3 71.68%
chia/wallet/wallet_node.py 3 86.39%
chia/server/server.py 4 84.05%
chia/server/node_discovery.py 11 79.61%
Totals Coverage Status
Change from base Build 19682443433: 0.2%
Covered Lines: 102650
Relevant Lines: 112766

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Changed Required label for PR that categorizes merge commit message as "Changed" for changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants