Merge pull request #83059 from akrieger/double_standards

Fix zzip build in mac&windows releases, add to make default target

Author: GuardianDll

Makefile

@@ -300,7 +300,7 @@ ifneq (,$(findstring mingw32,$(CROSS)))
   JSON_FORMATTER_BIN=tools/format/json_formatter.exe
 endif
 
-# Determine JSON formatter binary name
+# Determine zzip compression tool name
 ZZIP_BIN=zzip
 ifeq ($(MSYS2), 1)
   ZZIP_BIN=zzip.exe
@@ -1086,7 +1086,7 @@ endif
 
 LDFLAGS += -lz
 
-all: version prefix $(CHECKS) $(TARGET) $(L10N) $(TESTSTARGET)
+all: version prefix $(CHECKS) $(TARGET) $(L10N) $(TESTSTARGET) $(ZZIP_BIN)
 	@
 
 $(TARGET): $(OBJS)

tools/save/zzip_main.cpp

@@ -374,7 +374,7 @@ static int decompress_to( std::filesystem::path const &zzip_path,
         entry_map[filename] = std::move( *entry );
     }
 
-    for( const std::pair<std::string, ZzipEntry> &entry : entry_map ) {
+    for( const std::pair<const std::string, ZzipEntry> &entry : entry_map ) {
         const std::string &filename = entry.second.path;
         const char *entry_base = entry.second.base;
         size_t frame_size = entry.second.size;