feat: add ssh key authentication support#1602
feat: add ssh key authentication support#1602shivanshuraj1333 wants to merge 1 commit intoClickHouse:mainfrom
Conversation
7adac98 to
c532491
Compare
c532491 to
ec7a2fc
Compare
|
@ernado ptal when you've some bandwidth |
SpencerTorres
left a comment
There was a problem hiding this comment.
Similar comments to #1596, I think we should try to improve the testing here.
The unit tests can stay where they are, but it would be nice to have an integration test for this. We have a resources folder where we could mount and test SSH auth with the ClickHouse server container.
I like the client options, being able to provide a file path via URL seems convenient for external tools dependent on the driver + a URL. I think the custom signer is more useful though, I don't want to have too many file system operations within the driver so it's good to give the user that option.
I'm actually not familiar with the authentication process with SSH and ClickHouse. Can you provide some more info on the structure of the exchange and the limitations?
cb005ee to
ec7a2fc
Compare
Adds fix for #1601
related to:
ClickHouse/ch-go#350
ClickHouse/ch-go#1075
ClickHouse/ClickHouse#41109
Summary
Adds ssh key auth support
Checklist
Delete items not relevant to your PR: