std: support prepared SELECT/DDL via database/sql; add examples/tests#1658
Open
theboringhumane wants to merge 2 commits intoClickHouse:mainfrom
Open
std: support prepared SELECT/DDL via database/sql; add examples/tests#1658theboringhumane wants to merge 2 commits intoClickHouse:mainfrom
theboringhumane wants to merge 2 commits intoClickHouse:mainfrom
Conversation
Implement driver-side prepared statements for non-INSERT queries in the database/sql compatibility layer. Changes: - Introduce stdStmt and wire it into PrepareContext for non-INSERT statements - Implement StmtQueryContext/StmtExecContext using underlying connection - Preserve INSERT behavior via stdBatch (Exec-only) - Add example examples/std/prepared.go and run it in examples suite - Add tests: prepared select, USE + prepared select, and merged funds temp test - Remove temporary test file; fix minor linter warning in clickhouse_std.go Rationale: - Restores database/sql compatibility for prepared read queries (e.g., Stmt.QueryContext) while keeping batch INSERT semantics
Contributor
|
@theboringhumane thanks for the contribution. can you take care of the failing test cases?
|
Author
I'll take care of that. No sweat. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement driver-side prepared statements for non-INSERT queries in the database/sql compatibility layer.
Changes:
Introduce stdStmt and wire it into PrepareContext for non-INSERT statements
Implement StmtQueryContext/StmtExecContext using underlying connection
Preserve INSERT behavior via stdBatch (Exec-only)
Add example examples/std/prepared.go and run it in examples suite
Add tests: prepared select, USE + prepared select, and merged funds temp test
Remove temporary test file; fix minor linter warning in clickhouse_std.go
Rationale:
Summary
Checklist
Delete items not relevant to your PR: