Skip to content

Conversation

@Huckies
Copy link

@Huckies Huckies commented Sep 3, 2025

Proposed change

According to the physical mounting, curtain slider may work better with reversed percentage, this PR removes the limitation on cover entities while not affecting the other type of entities.

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Example printscreens/gif

{AFAA066D-E218-48E1-8289-37FA13F8DE73}

Additional information

Additional documentation needed.

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests screenshots/gifs have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

  • Documentation added/updated for readme.

@Huckies Huckies closed this Sep 18, 2025
@Clooos
Copy link
Owner

Clooos commented Sep 18, 2025

Hi! And thank you for your work on this! Why have you closed this PR?

@Huckies
Copy link
Author

Huckies commented Sep 18, 2025

Oh, I thought you didn't like this PR, so I switched to my own branch and created a release.

Verified to work and reopened, feel free to ask questions or merge.

@Huckies Huckies reopened this Sep 18, 2025
@Clooos
Copy link
Owner

Clooos commented Sep 22, 2025

Sorry my late answers, I'm so focused on my own changes that I forgot to answer 😅

I've checked your code but I will maybe use a different approach, I'll see (I've made a lot of changes to the sliders for the new slider sub-buttons).

@github-actions
Copy link

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
If you are the author of this PR, please leave a comment if you want to keep it open. Also, please rebase your PR onto the latest dev branch to ensure that it's up to date with the latest changes.
Thank you for your contribution!

@github-actions github-actions bot added the stale label Nov 21, 2025
@Clooos
Copy link
Owner

Clooos commented Nov 24, 2025

Hi again! I wanted to take a look at this but I realize that I don't clearly understand the use case, I've checked #1775 and #749 and I'm still lost with how it should works.

What I suggest here is to close this PR, and redoing it for the upcoming v3.1.0. But could you add one or more toggle in the editor instead? This would be easier to understand for the users, setting the steps to -1 doesn't feel intuitive. What do you think?

@github-actions github-actions bot removed the stale label Nov 24, 2025
@Huckies
Copy link
Author

Huckies commented Nov 27, 2025

Hi Clooos,

I wish to add toggles too, but I'm not familiar with CSS or javascript things, actually it's my first time writing in these languages.

The purpose is quite simple, the original slider can only match curtains physically installed on the left side and moving towards right when closing. If anyone's curtain is installed on the right side it's kind of counterintuitive. And if the curtain is two pieces of clothes closing to the center, even more.

So I'm offering a way to 'reverse' the slider: by setting it's start point to the right side, it can match the substance in real world, and one can set two symmetric sliders just like I do.
微信图片_20251127202627

Would you please add some toggle buttons decently in v3.1.0? I'm really clumsy at this while it helps a lot if the UI is more intuitive for users to understand the slider could be reversed.

@Clooos
Copy link
Owner

Clooos commented Dec 4, 2025

Hi! I've added this feature and more layout options for the sliders (in a new panel in the editor). I really think this will be much more user friendly. This will be available in the next v3.1.0 beta 😄

image

@Clooos Clooos closed this Dec 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Suggestion for improvement

2 participants