-
-
Notifications
You must be signed in to change notification settings - Fork 129
Added reverse percentage support for cover devices #1802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi! And thank you for your work on this! Why have you closed this PR? |
|
Oh, I thought you didn't like this PR, so I switched to my own branch and created a release. Verified to work and reopened, feel free to ask questions or merge. |
|
Sorry my late answers, I'm so focused on my own changes that I forgot to answer 😅 I've checked your code but I will maybe use a different approach, I'll see (I've made a lot of changes to the sliders for the new slider sub-buttons). |
|
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
|
Hi again! I wanted to take a look at this but I realize that I don't clearly understand the use case, I've checked #1775 and #749 and I'm still lost with how it should works. What I suggest here is to close this PR, and redoing it for the upcoming v3.1.0. But could you add one or more toggle in the editor instead? This would be easier to understand for the users, setting the steps to |


Proposed change
According to the physical mounting, curtain slider may work better with reversed percentage, this PR removes the limitation on
coverentities while not affecting the other type of entities.Type of change
Example configuration
Example printscreens/gif
Additional information
Additional documentation needed.
Checklist
If user exposed functionality or configuration variables are added/changed: