-
Notifications
You must be signed in to change notification settings - Fork 536
Fixed Issue #205 #214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Fixed Issue #205 #214
Conversation
Thanks @Astabol, please remove the comments you have introduced, since your changes are self-explanatory |
Sure. I shall remove. Thanks |
Hello @deRemo, I removed the comments. Thank You |
Thanks @Astabol, but please squash the commits into one for a cleaner git history I generally use More info: https://garrytrinder.github.io/2020/03/squashing-commits-using-interactive-rebase |
Hi @deRemo , I squashed the commits to single. Thank You |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this required for issue #205? I'd rather not touch the base simulation engine: I'm pretty sure that we want the simulator to fail if getIncomingEvents() is null-pointer, rather than "hiding" it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. I understand.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As my comment below, I'm not sure that hiding the nullpointer is the right approach. When calling getCurrentRequestedMips we basically assume that the Vm has been placed, hence getHost() shouldn't be null. I believe that the issue to be fixed is more intricate than this...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it is not fixing the root cause. If anyone called this from another example might get the same issue. I will look into it. Thank You
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your time!
Hello @qwsdl , This is the fixed for Fixed Issue #205.

Thank You