Skip to content

London | 25-SDC-July | Ali Qassab | Sprint 2 | Improve code with precomputing #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
AliQassab wants to merge 2 commits into
base: main
Choose a base branch
from
Open

London | 25-SDC-July | Ali Qassab | Sprint 2 | Improve code with precomputing #49

AliQassab wants to merge 2 commits into from

Conversation

@AliQassab
Copy link

@AliQassab AliQassab commented Oct 18, 2025 •
edited
Loading

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Optimized two functions with precomputing techniques:

  • count_letters: O(n) with set comprehensions for efficient character lookup
  • common_prefix: O(n log n) with sorting optimization to find longest common prefix between adjacent strings
    Both functions now handle large inputs efficiently while maintaining correct results.

Questions

Ready for review! All tests pass.

@AliQassab AliQassab added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Complexity The name of the module. labels Oct 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Module-Complexity The name of the module. Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@AliQassab