London | ITP-Sept-2025 | Mariia Serhiienko | Sprint 2 | Module Data Groups #902
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Konvaly
added
the
Needs Review
wheresdiasd
added
Review in progress
wheresdiasd
approved these changes
Dec 3, 2025
| }; | ||
|
|
||
| for (const value of author) { | ||
| for (const value of Object.values(author)) { |
There was a problem hiding this comment.
What about using a for in loop would that be more appropriate to objects?
Author
There was a problem hiding this comment.
I thought that we need to fix for..of loop that's why I used Object.values() - literatully it takes the object and returns an array of its values.
Do you reckon that my solution might be better to change with using for in loop?
wheresdiasd
added
Complete
|
Overall it looks good to me, left a suggestion but already consider it completed and approved. |
Author
|
Thanks a lot @wheresdiasd ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added tests and implemented solution for the debug, implement and interpret sections.