West Midlands | ITP-Sept-25 | Georgina Rogers | Sprint 3 | Alarm Clock

[zilinskyte]

Learners, PR Template

Self checklist

• I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
• My changes meet the requirements of the task
• I have tested my changes
• My changes follow the style guide

Changelist

Alarm clock function written, HTML improved for readability, and alarm tested in live server

Questions

Had to copy over all my changes from a another closed pull request due to conflicting changes.

[github-actions]

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

[github-actions]

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

[github-actions]

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

[github-actions]

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

[github-actions]

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

[cjyuan]

Code is very solid.

At "some point", the clock could appear as -1:-1. Is that what you intended?

[cjyuan]

(Optional change)
You could also consider structuring the HTML like this:

      <div id="timeRemaining" class="time-remaining">
        <div>Time Remaining:</div>
        <div id="timeDisplay">00:00</div>
      </div>

This approach has several benefits:

• Cleaner JavaScript: The JS only needs to update the dynamic value, not the static label.

• Better semantics: h1 is meant for page headings, while div or span is more appropriate for generic UI elements. Font size and visual hierarchy should be handled with CSS instead.

• More flexible layout: Avoid using <br> for spacing or layout in application UIs -- CSS provides far greater control and maintainability.

[cjyuan]

(Optional change)
You could also consider loading the JS code as an ES module:

<script src="alarmclock.js" type="module"></script>

This offers a couple of key advantages:

• defer is implied: Module scripts are loaded asynchronously and executed only after the HTML document has been fully parsed.

• Scoped execution: The code runs in the module scope, avoiding unintended pollution of the global namespace.

[cjyuan]

Changes are good. Indentation is a bit off after latest changes.