Skip to content

Manchester| 25-ITP-Sep| Fithi Teklom| Sprint 3 | Quote Generator App #915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Fithi-Teklom wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Manchester| 25-ITP-Sep| Fithi Teklom| Sprint 3 | Quote Generator App #915

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
96233e8
added a title
Fithi-Teklom Dec 6, 2025
5888597
linked the css file
Fithi-Teklom Dec 11, 2025
45fcc99
added a jest file
Fithi-Teklom Dec 11, 2025
fa5feab
wrapped the function inside windows load
Fithi-Teklom Dec 11, 2025
8fc17ce
added a space
Fithi-Teklom Dec 11, 2025
dfc616d
modified style css
Fithi-Teklom Dec 11, 2025
212fe40
added a switch on and off button
Fithi-Teklom Dec 11, 2025
13c8ab0
auto play is working
Fithi-Teklom Dec 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions Sprint-3/quote-generator/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,20 @@
<head>
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>Title here</title>
<title>Quote generator app</title>
<link rel="stylesheet" href="./style.css" />
<script defer src="quotes.js"></script>
</head>
<body>
<h1>hello there</h1>
<h1>Hello there</h1>
<p id="quote"></p>
<p id="author"></p>
<label class="switch">
<input type="checkbox" id="auto-play-toggle" />
<span class="slider"></span>
</label>
<p id="auto-status">auto-play:OFF</p>

<button type="button" id="new-quote">New quote</button>
</body>
</html>
4 changes: 4 additions & 0 deletions Sprint-3/quote-generator/jest.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
module.exports = {
testEnvironment: "jsdom",
testMatch: ["quote.test.js"],
};
8 changes: 6 additions & 2 deletions Sprint-3/quote-generator/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,13 @@
"version": "1.0.0",
"license": "CC-BY-SA-4.0",
"description": "You must update this package",
"scripts": {
"test": "jest --config=../jest.config.js quote-generator"
"devDependencies": {
"@testing-library/user-event": "13.5.0"
},
"scripts": {
"test": "jest"
},

"repository": {
"type": "git",
"url": "git+https://github.com/CodeYourFuture/CYF-Coursework-Template.git"
Expand Down
50 changes: 49 additions & 1 deletion Sprint-3/quote-generator/quotes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,57 @@

// You don't need to change this function
function pickFromArray(choices) {
return choices[Math.floor(Math.random() * choices.length)];
// You already have pickFromArray() and quotes[] above this comment
return choices[Math.floor(Math.random() * choices.length)]
};
window.addEventListener("load", () => {
const quoteEl = document.getElementById("quote");
const authorEl = document.getElementById("author");
const button = document.getElementById("new-quote");

// Generate a random quote using Math.random (required for tests)
function getRandomQuote() {
const index = Math.floor(Math.random() * quotes.length);
return quotes[index];
}

// Put the quote + author into the DOM
function displayRandomQuote() {
const q = getRandomQuote();
quoteEl.textContent = q.quote;
authorEl.textContent = q.author;
}
Comment on lines +24 to 39
Copy link
Contributor

@cjyuan cjyuan Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could consider declaring top-level variables and defining functions outside of the onload event listener. Doing so could make finding out "what operations are performed once on page load" easier.


// Show initial quote immediately
displayRandomQuote();

// Button shows a new quote
button.addEventListener("click", displayRandomQuote);
let autoPlayInterval = null;

const toggle = document.getElementById("auto-play-toggle");
const statusText = document.getElementById("auto-status");

toggle.addEventListener("change", () => {
if (toggle.checked) {
statusText.textContent = "auto-play:ON";

// Change every 5 seconds (easy for testing)
autoPlayInterval = setInterval(() => {
pickQuoteAndAuthor();
}, 5000);

pickQuoteAndAuthor(); // Change immediately
} else {
statusText.textContent = "auto-play:OFF";
clearInterval(autoPlayInterval);
}
});
Comment on lines 46 to 67
Copy link
Contributor

@cjyuan cjyuan Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could consider wrapping all the code and variables needed to support auto-play inside a function as:

function setupAutoPlay() {
  // JavaScript support closure. So even after this function call returns, the 
  // inner function can still access these variables.
  let autoPlayInterval = null;
  const toggle = document.getElementById("auto-play-toggle");
  const statusText = document.getElementById("auto-status");

  toggle.addEventListener("change", () => {
     ...
  });
}

and then call the function in the onload event listener as

window.addEventListener("load", () => {

  button.addEventListener("click", displayRandomQuote);

  // By placing the setup code in a separate function, it makes finding out "what operations are
  // performed once on page load" easier.
  setupAutoPlay();

  displayRandomQuote();
});



// return choices[Math.floor(Math.random() * choices.length)];
});

// A list of quotes you can use in your app.
// DO NOT modify this array, otherwise the tests may break!
const quotes = [
Expand Down
4 changes: 3 additions & 1 deletion Sprint-3/quote-generator/quotes.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ There are some Tests in this file that will help you work out if your code is wo
const path = require("path");
const { JSDOM } = require("jsdom");

require("@testing-library/jest-dom");

let page = null;

beforeEach(async () => {
Expand Down Expand Up @@ -34,7 +36,7 @@ beforeEach(async () => {
});
});

afterEach(() => {
afterEach(() => {
page = null;
jest.restoreAllMocks();
});
Expand Down
108 changes: 108 additions & 0 deletions Sprint-3/quote-generator/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,109 @@
/** Write your CSS in here **/

body {
font-family: Arial, sans-serif;
background: linear-gradient(135deg, #f089cc, #d6eaff);
margin: 0;
padding: 40px;
text-align: center;
}

/* Page title */
h1 {
color: black ;
font-size: 2rem;
margin-bottom: 20px;
}

/* Quote styling */
#quote {
font-size: 1.5rem;
font-weight: bold;
color: black ;
margin: 20px auto 10px;
max-width: 600px;
line-height: 1.5;
}

/* Author name */
#author {
font-size: 1.2rem;
color: #555;
margin-bottom: 30px;
}

/* Button styling */
#new-quote {
padding: 12px 30px;
font-size: 1rem;
background-color: #007bff;
color: white;
border: none;
border-radius: 8px;
cursor: pointer;
transition: 0.25s ease;
}

/* Hover effect */
#new-quote:hover {
background-color: #005ec2;
transform: scale(1.05);
}


/* Toggle switch container */
.switch {
position: relative;
display: inline-block;
width: 50px;
height: 26px;
margin-top: 20px;
}

/* Hide default checkbox */
.switch input {
opacity: 0;
width: 0;
height: 0;
}

/* Slider background */
.slider {
position: absolute;
cursor: pointer;
top: 0;
left: 0;
right: 0;
bottom: 0;
background-color: #ccc;
border-radius: 26px;
transition: 0.4s;
}

/* Slider circle */
.slider:before {
position: absolute;
content: "";
height: 20px;
width: 20px;
left: 3px;
bottom: 3px;
background-color: white;
border-radius: 50%;
transition: 0.4s;
}

/* ON state */
input:checked + .slider {
background-color: #4a90e2;
}

input:checked + .slider:before {
transform: translateX(24px);
}

#auto-status {
margin-top: 10px;
color: #333;
font-weight: bold;
}
8 changes: 8 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"devDependencies": {
"@testing-library/jest-dom": "^6.9.1",
"@testing-library/user-event": "^13.5.0",
"jest": "^30.2.0",
"jsdom": "^19.0.0"
}
}