NW | 25-ITP-Sep | Ahmad Hmedan | Sprint 3 | quote generator app #917
Conversation
|
Your PR's title isn't in the expected format. Please check the expected title format, and update yours to match. Reason: Wrong number of parts separated by |s If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above. |
AhmadHmedann
changed the title
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above. |
1 similar comment
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above. |
AhmadHmedann
added
the
Needs Review
| function generateRandomQuote(){ | ||
| const myObj =pickFromArray(quotes); | ||
| document.getElementById("quote-text").textContent=`${myObj.quote}` | ||
| document.getElementById("quote-author").textContent=`-${myObj.author}` |
There was a problem hiding this comment.
Could consider placing the - part (a piece of static content) in HTML or inserted via CSS.
cjyuan
added
Complete
Have you tried asking AI?
Consider it a stretch exercise. |
2 participants
Learners, PR Template
Self checklist
Changelist
update HTML & CSS and complete the code in JS file
Questions
What is the difference between generateRandomQuote with () and without brackets?
One last question: do I need to run the test file?
Thanks in advance