West Midlands | ITP-Sept-2025 | Hadi Vahidi | Sprint 3 | Alarm Clock #920
+73
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HadiVahidi20
added
the
Needs Review
cjyuan
reviewed
Dec 14, 2025
Contributor
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
There are something in index.html you haven't yet updated.
| @@ -1,6 +1,33 @@ | |||
| function setAlarm() {} | |||
| let countdown; | ||
|
|
||
| function setAlarm() { | ||
| let seconds = Number(document.getElementById("alarmSet").value); |
Contributor
There was a problem hiding this comment.
Without proper validation or pre-processing, some unusual input values can make your app behave abnormally. Can you add code to sanitise the input?
| } | ||
|
|
||
| updateDisplay(); | ||
| clearInterval(countdown); |
Contributor
There was a problem hiding this comment.
Can you think of anything else that should also be reset?
cjyuan
added
Reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Questions