West Midlands | 25-ITP-Sept | Mustaf Asani | Sprint 3 | Feature/alarmclock #921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asaniDev
added
Needs Review
cjyuan
reviewed
Dec 9, 2025
| playAlarm(); | ||
| } | ||
| displayTime(inputTime); | ||
| if (timer) clearInterval(timer); |
Contributor
There was a problem hiding this comment.
What else should also be reset before starting a new countdown?
| function setAlarm() { | ||
| inputTime = Number(document.querySelector("#alarmSet").value); | ||
|
|
||
| if (Number.isInteger(inputTime) && !isNaN(inputTime) && inputTime >= 0) { |
Contributor
There was a problem hiding this comment.
One of the checks is redundant.
Comment on lines
+11
to
+15
| } else if (inputTime === 0) { | ||
| displayTime(inputTime); | ||
| playAlarm(); | ||
| } | ||
| displayTime(inputTime); |
Contributor
There was a problem hiding this comment.
When inputTime is zero, some of your code are unnecessary executed.
Contributor
There was a problem hiding this comment.
Could consider replacing
<h1 id="timeRemaining">Time Remaining: 00:00</h1>
by
<div id="timeRemaining">Time Remaining: <span id="theTime">00:00</span></div>
Suggestion: Use AI to find out why the latter is better.
cjyuan
added
Reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Added functions to alarm to make the timer count down from input time and alarm to off when it reaches 0.