Manchester| 25-ITP-Sep | khalidbih | Sprint 1 | data-group l sprint-1

Sprint-1/fix/median.js

@@ -6,9 +6,30 @@
 // or 'list' has mixed values (the function is expected to sort only numbers).
 
 function calculateMedian(list) {
-  const middleIndex = Math.floor(list.length / 2);
-  const median = list.splice(middleIndex, 1)[0];
-  return median;
+
+  if (!Array.isArray(list)) {
+    return null;
+  }
+  if (list.length === 0) {
+    return null;
+  }
+
+  const numericList = list.filter(item => typeof item === "number" && !isNaN(item));
+
+  if (numericList.length === 0) {
+    return null;
+  }
+
+  const sortedList = [...numericList].sort((a, b) => a - b);
+  const length = sortedList.length;
+  const middleIndex = Math.floor(length / 2);
+
+  if (length % 2 === 0) {
+    return (sortedList[middleIndex - 1] + sortedList[middleIndex]) / 2;
+  } else {
+    return sortedList[middleIndex];
+  }
 }
 
 module.exports = calculateMedian;
+

Sprint-1/implement/dedupe.js

@@ -1 +1,14 @@
-function dedupe() {}
+function dedupe(arr) {
+    const seen = new Set();
+    const result = []
+    for (const item of arr){
+        if (!seen.has(item)){
+            seen.add(item);
+            result.push(item);
+         }
+        }   
+        return result
+      }
+
+      module.exports = dedupe;
+

Sprint-1/implement/dedupe.test.js

@@ -11,17 +11,28 @@ E.g. dedupe([5, 1, 1, 2, 3, 2, 5, 8]) target output: [5, 1, 2, 3, 8]
 E.g. dedupe([1, 2, 1]) target output: [1, 2]
 */
 
+
 // Acceptance Criteria:
 
 // Given an empty array
 // When passed to the dedupe function
 // Then it should return an empty array
-test.todo("given an empty array, it returns an empty array");
-
+test("given an empty array, it returns an empty array",() => {
+  expect(dedupe([])).toEqual([]);
+});
+
 // Given an array with no duplicates
 // When passed to the dedupe function
 // Then it should return a copy of the original array
+test("returns the same array if there are no duplicates", () => {
+    expect(dedupe([1, 2, 3])).toEqual([1, 2, 3]);
+  });
 
 // Given an array with strings or numbers
 // When passed to the dedupe function
 // Then it should remove the duplicate values, preserving the first occurence of each element
+it("removes duplicates and keeps the first occurrence", () => {
+    expect(dedupe([1, 2, 1, 3, 2])).toEqual([1, 2, 3]);
+    expect(dedupe(["a", "a", "b", "a", "c"])).toEqual(["a", "b", "c"]);
+  });
+

Sprint-1/implement/max.js

@@ -1,4 +1,18 @@
 function findMax(elements) {
+  if (elements.length === 0) {
+    return -Infinity;
+  }
+
+  let max = -Infinity;
+
+  for (const item of elements) {
+    if (typeof item === "number" && item > max) {
+      max = item;
+    }
+  }
+
+  return max;
 }
 
 module.exports = findMax;
+

Sprint-1/implement/max.test.js

@@ -16,28 +16,49 @@ const findMax = require("./max.js");
 // When passed to the max function
 // Then it should return -Infinity
 // Delete this test.todo and replace it with a test.
-test.todo("given an empty array, returns -Infinity");
+test("given an empty array, returns -Infinity", () => {
+      expect(findMax([])).toBe(-Infinity);
+});
 
 // Given an array with one number
 // When passed to the max function
 // Then it should return that number
+test("given an array with one number, it returns that number", () => {
+  expect(findMax([7])).toBe(7);
+});
 
 // Given an array with both positive and negative numbers
 // When passed to the max function
 // Then it should return the largest number overall
+test("given positive and negative numbers, it returns the largest number", () => {
+  expect(findMax([-5, 10, -2, 7])).toBe(10);
+});
 
 // Given an array with just negative numbers
 // When passed to the max function
 // Then it should return the closest one to zero
+test("given an array with just negative numbers, it returns the closest to zero", () => {
+  expect(findMax([-10, -3, -20])).toBe(-3);
+});
 
 // Given an array with decimal numbers
 // When passed to the max function
 // Then it should return the largest decimal number
+test("given an array with decimal numbers, it returns the largest decimal number", () => {
+  expect(findMax([1.2, 3.5, 2.8])).toBe(3.5);
+});
 
 // Given an array with non-number values
 // When passed to the max function
 // Then it should return the max and ignore non-numeric values
+test("given an array with non-number values, it returns the max and ignores non-numeric values", () => {
+  expect(findMax(["hi", 10, "hello", 60, false, 20])).toBe(60);
+});
 
 // Given an array with only non-number values
 // When passed to the max function
 // Then it should return the least surprising value given how it behaves for all other inputs
+test("given an array with only non-number values, it returns -Infinity", () => {
+  expect(findMax(["a", "hello", false, null, undefined])).toBe(-Infinity);
+});
+

Sprint-1/implement/sum.js

@@ -1,4 +1,11 @@
 function sum(elements) {
+  let total = 0;
+  for (const el of elements) {
+    if (typeof el === "number") {
+      total += el;
+    }
+  }
+  return total;
 }
-
 module.exports = sum;
+

Sprint-1/implement/sum.test.js

@@ -13,24 +13,41 @@ const sum = require("./sum.js");
 // Given an empty array
 // When passed to the sum function
 // Then it should return 0
-test.todo("given an empty array, returns 0")
+test("given an empty array, returns 0", () => {
+  expect(sum([])).toBe(0);
+});
 
 // Given an array with just one number
 // When passed to the sum function
 // Then it should return that number
+test("given an array with one number, returns that number", () => {
+    expect(sum([7])).toBe(7);
+});
 
 // Given an array containing negative numbers
 // When passed to the sum function
 // Then it should still return the correct total sum
+test("given an array containing negative numbers, returns the correct sum", () => {
+    expect(sum([10, -5, 3, -2])).toBe(6); 
+});
 
 // Given an array with decimal/float numbers
 // When passed to the sum function
 // Then it should return the correct total sum
+test("given an array with decimal numbers, returns the correct sum", () => {
+    expect(sum([1.2, 3.5, 2.3])).toBe(7.0); 
+});
 
 // Given an array containing non-number values
 // When passed to the sum function
 // Then it should ignore the non-numerical values and return the sum of the numerical elements
+test("given an array with non-number values, returns the sum of numerical elements only", () => {
+    expect(sum([10, "hi", 5, null, 3, "hello"])).toBe(18); 
+});
 
 // Given an array with only non-number values
 // When passed to the sum function
 // Then it should return the least surprising value given how it behaves for all other inputs
+test("given an array with only non-number values, returns 0", () => {
+    expect(sum(["a", "hi", null, undefined, false])).toBe(0);
+});

Sprint-1/refactor/includes.js

@@ -1,8 +1,6 @@
 // Refactor the implementation of includes to use a for...of loop
-
 function includes(list, target) {
-  for (let index = 0; index < list.length; index++) {
-    const element = list[index];
+  for (const element of list) {
     if (element === target) {
       return true;
     }
@@ -11,3 +9,5 @@ function includes(list, target) {
 }
 
 module.exports = includes;
+
+