-
-
Notifications
You must be signed in to change notification settings - Fork 272
Refactor/implement rewrite coverage #858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
fdc0069
6825f69
be5d5ca
cad7330
7cbd9b7
bb78124
ed33a43
6678a10
716a310
f6933d2
7dad219
ec26710
64d8f8e
5c265f2
b45e475
69c7817
baaf318
003b0ec
4c72c29
daece44
7ffdf3b
fff9ffb
e988e4e
61e08e2
50fd116
c15ff9e
f07827b
4ac1f84
af00810
ba84bab
d6d1d7e
3c050ab
00756ef
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| name: Test Coverage Report - Implement and rewrite | ||
|
|
||
| on: | ||
| pull_request: | ||
| branches: | ||
| - main | ||
| paths: | ||
| - 'Sprint-3/1-implement-and-rewrite-tests/**' | ||
|
|
||
| jobs: | ||
| test-coverage: | ||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@v3 | ||
|
|
||
| - name: Setup Node.js | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: '20' | ||
| cache: 'npm' | ||
|
|
||
| - name: Install dependencies | ||
| run: npm ci | ||
|
|
||
| - name: Run Inline Assertion Tests & Verify Parity | ||
| run: node scripts/run-inline-tests.js | ||
| continue-on-error: true | ||
|
|
||
| - name: Run Jest Tests with Coverage | ||
| run: npx jest --config=jest.config.jest-tests.js --coverage --ci | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| name: Test Coverage Report - Practice TDD | ||
|
|
||
| on: | ||
| pull_request: | ||
| branches: | ||
| - main | ||
| paths: | ||
| - 'Sprint-3/2-practice-tdd/**' | ||
|
|
||
| jobs: | ||
| test-coverage: | ||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@v3 | ||
|
|
||
| - name: Setup Node.js | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: '20' | ||
| cache: 'npm' | ||
|
|
||
| - name: Install dependencies | ||
| run: npm ci | ||
|
|
||
| - name: Run Jest Tests with Coverage | ||
| run: npx jest --config=jest.config.jest-tests.js --coverage --ci |
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This file looks the same as for coverage-2. Could they be combined? |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| name: Test Coverage Report - Stretch | ||
|
|
||
| on: | ||
| pull_request: | ||
| branches: | ||
| - main | ||
| paths: | ||
| - 'Sprint-3/3-stretch/**' | ||
|
|
||
| jobs: | ||
| test-coverage: | ||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@v3 | ||
|
|
||
| - name: Setup Node.js | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: '20' | ||
| cache: 'npm' | ||
|
|
||
| - name: Install dependencies | ||
| run: npm ci | ||
|
|
||
| - name: Run Jest Tests with Coverage | ||
| run: npx jest --config=jest.config.jest-tests.js --coverage --ci |
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Test coverage runs for task 2 and task 3 in this sprint. Either the instructions should be replicated in those readmes, or a more general set of instructions should be given in the main sprint3 readme rather than here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the npm test command is defined in the package.json.Is there a reason you use npx to run the same command here?