London | 25-ITP-Sept | Samuel Tarawally | Sprint 3 | Implement and rewrite tests

.tool-versions

@@ -0,0 +1 @@
+nodejs 25.1.0

Sprint-3/1-implement-and-rewrite-tests/implement/1-get-angle-type.js

@@ -11,8 +11,28 @@ function getAngleType(angle) {
   if (angle === 90) {
     return "Right angle";
   }
-   // Run the tests, work out what Case 2 is testing, and implement the required code here.
-   // Then keep going for the other cases, one at a time.
+  // Run the tests, work out what Case 2 is testing, and implement the required code here.
+  // Then keep going for the other cases, one at a time.
+
+  // Case 2: Identify Acute Angles
+  if (angle < 90) {
+    return "Acute angle";
+  }
+
+  // Case 3: Identify Obtuse Angles
+  if (angle > 90 && angle < 180) {
+    return "Obtuse angle";
+  }
+
+  // Case 4: Identify Straight Angles
+  if (angle === 180) {
+    return "Straight angle";
+  }
+
+  // Case 5: Identify Reflex Angles
+  if (angle > 180 && angle < 360) {
+    return "Reflex angle";
+  }
 }
 
 // The line below allows us to load the getAngleType function into tests in other files.
@@ -51,13 +71,18 @@ assertEquals(acute, "Acute angle");
 // Then the function should return "Obtuse angle"
 const obtuse = getAngleType(120);
 // ====> write your test here, and then add a line to pass the test in the function above
+assertEquals(obtuse, "Obtuse angle");
 
 // Case 4: Identify Straight Angles:
 // When the angle is exactly 180 degrees,
 // Then the function should return "Straight angle"
 // ====> write your test here, and then add a line to pass the test in the function above
+const straight = getAngleType(180);
+assertEquals(straight, "Straight angle");
 
 // Case 5: Identify Reflex Angles:
 // When the angle is greater than 180 degrees and less than 360 degrees,
 // Then the function should return "Reflex angle"
-// ====> write your test here, and then add a line to pass the test in the function above
+// ====> write your test here, and then add a line to pass the test in the function above
+const reflex = getAngleType(270);
+assertEquals(reflex, "Reflex angle");

Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js

@@ -8,9 +8,12 @@
 // write one test at a time, and make it pass, build your solution up methodically
 
 function isProperFraction(numerator, denominator) {
-  if (numerator < denominator) {
-    return true;
-  }
+  // A proper fraction is defined as a fraction a/b where:
+  // 1. The numerator (a) is a positive integer
+  // 2. The denominator (b) is a positive integer
+  // 3. The absolute value of the numerator is less than the absolute value of the denominator:
+  //    |a| < |b|
+  return Math.abs(numerator) < Math.abs(denominator);
 }
 
 // The line below allows us to load the isProperFraction function into tests in other files.
@@ -46,14 +49,22 @@ assertEquals(improperFraction, false);
 // target output: true
 // Explanation: The fraction -4/7 is a proper fraction because the absolute value of the numerator (4) is less than the denominator (7). The function should return true.
 const negativeFraction = isProperFraction(-4, 7);
-// ====> complete with your assertion
+assertEquals(negativeFraction, true);
 
 // Equal Numerator and Denominator check:
 // Input: numerator = 3, denominator = 3
 // target output: false
 // Explanation: The fraction 3/3 is not a proper fraction because the numerator is equal to the denominator. The function should return false.
 const equalFraction = isProperFraction(3, 3);
-// ====> complete with your assertion
+assertEquals(equalFraction, false);
 
 // Stretch:
 // What other scenarios could you test for?
+
+// Given the definition of a proper fraction, cases involving values such as zero or floating-point numbers should be considered false as they are not positive integers (natural numbers):
+// - Where either the numerator or denominator is zero, the function should return false.
+// - Floating-point numbers in the function should return false, as proper fractions are defined for integers only.
+
+// The method `Number.isInteger()` can be used to check for positive integers by:
+// - Using `Math.abs()` to handle negative values when comparing numerator and denominator.
+// - Then checking if both numerator and denominator are positive integers using `Number.isInteger()` and greater than zero.

Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js

@@ -8,9 +8,12 @@
 // write one test at a time, and make it pass, build your solution up methodically
 // just make one change at a time -- don't rush -- programmers are deep and careful thinkers
 function getCardValue(card) {
-  if (rank === "A") {
-    return 11;
-  }
+  const rank = card.slice(0, -1);
+  if (rank === "A") return 11;
+  if (rank === "J" || rank === "Q" || rank === "K" || rank === "10") return 10;
+  const numValue = parseInt(rank);
+  if (numValue >= 2 && numValue <= 9) return numValue;
+  throw new Error("Invalid card rank");
 }
 
 // The line below allows us to load the getCardValue function into tests in other files.
@@ -31,27 +34,54 @@ function assertEquals(actualOutput, targetOutput) {
 // Given a card string in the format "A♠" (representing a card in blackjack - the last character will always be an emoji for a suit, and all characters before will be a number 2-10, or one letter of J, Q, K, A),
 // When the function getCardValue is called with this card string as input,
 // Then it should return the numerical card value
-const aceofSpades = getCardValue("A♠");
-assertEquals(aceofSpades, 11);
+
+const aceOfSpades = getCardValue("A♠");
+assertEquals(aceOfSpades, 11);
 
 // Handle Number Cards (2-10):
 // Given a card with a rank between "2" and "9",
 // When the function is called with such a card,
 // Then it should return the numeric value corresponding to the rank (e.g., "5" should return 5).
-const fiveofHearts = getCardValue("5♥");
-// ====> write your test here, and then add a line to pass the test in the function above
+
+const fiveOfHearts = getCardValue("5♥");
+assertEquals(fiveOfHearts, 5);
+const twoOfDiamonds = getCardValue("2♦");
+assertEquals(twoOfDiamonds, 2);
+const nineOfSpades = getCardValue("9♠");
+assertEquals(nineOfSpades, 9);
 
 // Handle Face Cards (J, Q, K):
 // Given a card with a rank of "10," "J," "Q," or "K",
 // When the function is called with such a card,
 // Then it should return the value 10, as these cards are worth 10 points each in blackjack.
 
+const kingOfHearts = getCardValue("K♥");
+assertEquals(kingOfHearts, 10);
+const queenOfSpades = getCardValue("Q♠");
+assertEquals(queenOfSpades, 10);
+const jackOfDiamonds = getCardValue("J♦");
+assertEquals(jackOfDiamonds, 10);
+const tenOfClubs = getCardValue("10♣");
+assertEquals(tenOfClubs, 10);
+
 // Handle Ace (A):
 // Given a card with a rank of "A",
 // When the function is called with an Ace,
 // Then it should, by default, assume the Ace is worth 11 points, which is a common rule in blackjack.
 
+const aceOfHearts = getCardValue("A♥");
+assertEquals(aceOfHearts, 11);
+
 // Handle Invalid Cards:
 // Given a card with an invalid rank (neither a number nor a recognized face card),
 // When the function is called with such a card,
 // Then it should throw an error indicating "Invalid card rank."
+
+try {
+  getCardValue("X♠");
+  console.assert(false, "Should have thrown an error for invalid card");
+} catch (error) {
+  assertEquals(error.message, "Invalid card rank");
+}
+
+console.log("✅ All tests passed!");

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js

@@ -6,21 +6,27 @@ test("should identify right angle (90°)", () => {
   expect(getAngleType(90)).toEqual("Right angle");
 });
 
-// REPLACE the comments with the tests
-// make your test descriptions as clear and readable as possible
-
-// Case 2: Identify Acute Angles:
-// When the angle is less than 90 degrees,
-// Then the function should return "Acute angle"
+test("should identify acute angle (< 90°)", () => {
+  expect(getAngleType(45)).toEqual("Acute angle");
+  expect(getAngleType(30)).toEqual("Acute angle");
+  expect(getAngleType(1)).toEqual("Acute angle");
+  expect(getAngleType(89)).toEqual("Acute angle");
+});
 
-// Case 3: Identify Obtuse Angles:
-// When the angle is greater than 90 degrees and less than 180 degrees,
-// Then the function should return "Obtuse angle"
+test("should identify obtuse angle (> 90° and < 180°)", () => {
+  expect(getAngleType(120)).toEqual("Obtuse angle");
+  expect(getAngleType(135)).toEqual("Obtuse angle");
+  expect(getAngleType(91)).toEqual("Obtuse angle");
+  expect(getAngleType(179)).toEqual("Obtuse angle");
+});
 
-// Case 4: Identify Straight Angles:
-// When the angle is exactly 180 degrees,
-// Then the function should return "Straight angle"
+test("should identify straight angle (180°)", () => {
+  expect(getAngleType(180)).toEqual("Straight angle");
+});
 
-// Case 5: Identify Reflex Angles:
-// When the angle is greater than 180 degrees and less than 360 degrees,
-// Then the function should return "Reflex angle"
+test("should identify reflex angle (> 180° and < 360°)", () => {
+  expect(getAngleType(270)).toEqual("Reflex angle");
+  expect(getAngleType(181)).toEqual("Reflex angle");
+  expect(getAngleType(359)).toEqual("Reflex angle");
+  expect(getAngleType(200)).toEqual("Reflex angle");
+});

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js

@@ -6,8 +6,20 @@ test("should return true for a proper fraction", () => {
   expect(isProperFraction(2, 3)).toEqual(true);
 });
 
-// Case 2: Identify Improper Fractions:
+test("should return false for an improper fraction (numerator >= denominator)", () => {
+  expect(isProperFraction(5, 2)).toEqual(false);
+  expect(isProperFraction(10, 3)).toEqual(false);
+  expect(isProperFraction(7, 7)).toEqual(false);
+});
 
-// Case 3: Identify Negative Fractions:
+test("should return true for a negative proper fraction (|numerator| < denominator)", () => {
+  expect(isProperFraction(-4, 7)).toEqual(true);
+  expect(isProperFraction(-2, 5)).toEqual(true);
+  expect(isProperFraction(-1, 10)).toEqual(true);
+});
 
-// Case 4: Identify Equal Numerator and Denominator:
+test("should return false when numerator equals denominator", () => {
+  expect(isProperFraction(3, 3)).toEqual(false);
+  expect(isProperFraction(1, 1)).toEqual(false);
+  expect(isProperFraction(100, 100)).toEqual(false);
+});

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js

@@ -7,7 +7,34 @@ test("should return 11 for Ace of Spades", () => {
   expect(aceofSpades).toEqual(11);
 });
 
-// Case 2: Handle Number Cards (2-10):
-// Case 3: Handle Face Cards (J, Q, K):
-// Case 4: Handle Ace (A):
-// Case 5: Handle Invalid Cards:
+test("should return correct value for number cards (2-9)", () => {
+  expect(getCardValue("2♦")).toEqual(2);
+  expect(getCardValue("3♣")).toEqual(3);
+  expect(getCardValue("4♥")).toEqual(4);
+  expect(getCardValue("5♥")).toEqual(5);
+  expect(getCardValue("6♠")).toEqual(6);
+  expect(getCardValue("7♦")).toEqual(7);
+  expect(getCardValue("8♣")).toEqual(8);
+  expect(getCardValue("9♥")).toEqual(9);
+});
+
+test("should return 10 for face cards (J, Q, K, 10)", () => {
+  expect(getCardValue("10♣")).toEqual(10);
+  expect(getCardValue("J♦")).toEqual(10);
+  expect(getCardValue("Q♠")).toEqual(10);
+  expect(getCardValue("K♥")).toEqual(10);
+});
+
+test("should return 11 for all Aces", () => {
+  expect(getCardValue("A♠")).toEqual(11);
+  expect(getCardValue("A♥")).toEqual(11);
+  expect(getCardValue("A♦")).toEqual(11);
+  expect(getCardValue("A♣")).toEqual(11);
+});
+
+test("should throw an error for invalid card rank", () => {
+  expect(() => getCardValue("X♠")).toThrow("Invalid card rank");
+  expect(() => getCardValue("Z♥")).toThrow("Invalid card rank");
+  expect(() => getCardValue("11♦")).toThrow("Invalid card rank");
+  expect(() => getCardValue("0♣")).toThrow("Invalid card rank");
+});