Add potentially ignorable permissions errors #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are times where if we can get extra information we want to show it, but if not we want to show what information we have. For instance, we currently have a staff view and a non-staff view of the "reviewers" dashboard. This construction will allow us to just try to get the staff-only information, and if it can be fetched, show it, and if not, just not show it. We can collapse two views into one. The down side here is if someone _should_ have access to the staff view, they may not notice that they're missing some extra data.
Rather than separate links
illicitonion
force-pushed
the
ignorable-permissions
branch
from
c99ee0c to
0080bb6
Compare
AnnaFYZ
approved these changes
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are times where if we can get extra information we want to show
it, but if not we want to show what information we have. For instance,
we currently have a staff view and a non-staff view of the "reviewers"
dashboard. This construction will allow us to just try to get the
staff-only information, and if it can be fetched, show it, and if not,
just not show it. We can collapse two views into one. The down side here
is if someone should have access to the staff view, they may not
notice that they're missing some extra data.
This PR has two commits - one adds the ignorable permissions error, and the other consumes it for reviewers staff-only information.