-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
ISort, various new checks, problem matchers and more - configs #4890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Jackenmen
wants to merge
11
commits into
Cog-Creators:V3/develop
Choose a base branch
from
Jackenmen:V3/linter_stuff
base: V3/develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
78a5c7f to
326d5a0
Compare
4349da1 to
194c012
Compare
c0220c4 to
1d38466
Compare
0a9f51e to
07d2caa
Compare
07d2caa to
0ccf6a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Blocked By: Other PR
Blocked by another PR.
Category: CI
This is related to repository's CI configuration.
Category: Docs - Other
This is related to documentation that doesn't have its dedicated label.
Category: Meta
This is related to the repository maintenance.
Type: Bug
Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing.
Type: Enhancement
Something meant to enhance existing Red features.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Description of the changes
List of changes to be completed...
Notes:
make stylediffreports diffs separatelybut I think it's just an unnecessary maintenance burden. Here's a link in case someone is
interested in this work though:
563b94a
make stylediffcompletely since it was primarily added foruse in CI but it isn't much of a burden to at least keep it in this form and it might be
useful for some people's workflows.
pre-commitusage should, however, be preferred.TODO:
tests/after figuring out a proper way to minimize the issues with the importsmake newenv+pre-commit installcombinedmake newenvafter it finishes everything elsepretty-format-jsonhook"Things that I have considered but ended up not doing:
pre-commit run --all-filesreformat,stylecheck, orstylediffas not all hooks are able to automatically reformat the filesan installed pre-commit hook, it already runs in CI, and it isn't particularly
hard for people to run
pre-commit run --all-filesif that's their preferred workflownewenvrecipe in MakefileThe reformatting needed by this PR is done in #4894 and that PR should be merged before this one.
Link to problem matcher preview: 6378fdf (can also be seen on the "Files changes" page in "Unchanged files with check annotations" section)
Fixes #3882, fixes #4698
Blocked by #4894 (the one that actually does the reformatting)