Skip to content

ISort, various new checks, problem matchers and more - reformat #4894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 66 commits into
base: V3/develop
Choose a base branch
from
Draft

ISort, various new checks, problem matchers and more - reformat #4894

wants to merge 66 commits into from

Conversation

@Jackenmen
Copy link
Member

@Jackenmen Jackenmen commented Mar 16, 2021

Type

  • Bugfix
  • Enhancement
  • New feature

Description of the changes

#4890 should be discussed and reviewed first, but this PR should be the one that actually gets merged first.
This should come naturally - all the checks that are configured in #4890 won't pass without the changes made here but the changes here don't contradict any existing code standards in Red.

The changes in this PR will mostly be a formality (the changes here should still be looked through though) as anything that people disagree with should be decided within #4890.

@Jackenmen Jackenmen added the Category: Meta This is related to the repository maintenance. label Mar 16, 2021
@Jackenmen Jackenmen marked this pull request as draft March 16, 2021 02:03
@github-actions github-actions bot added Category: Cogs - Admin This is related to the Admin cog. Category: Cogs - Alias This is related to the Alias cog. Category: Cogs - Audio This is related to the Audio cog. Category: Core - API - Bank This is related to the core Bank API. Category: Cogs - Bank (historical) This is related to the Bank cog. Category: Bot Core Category: Cogs - Cleanup This is related to the Cleanup cog. Category: Core - API - Config This is related to the `redbot.core.config` module and `redbot.core.drivers` package. Category: Cogs - CustomCommands This is related to the CustomCommands cog. Category: Cogs - Dev This is related to the Dev cog. Category: Docs - Other This is related to documentation that doesn't have its dedicated label. Category: Cogs - Downloader This is related to the Downloader cog. Category: Cogs - Economy This is related to the Economy cog. Category: Cogs - Filter This is related to the Filter cog. Category: Cogs - General This is related to the General cog. Category: Core - Help This is related to our help command and/or HelpFormatter API. Category: Core - i18n This is related to the i18n core API or locale files. Category: Cogs - Image This is related to the Image cog. Category: Cogs - Mod This is related to the Mod cog. Category: Core - Modlog This is related to the core Modlog API. Category: Cogs - Modlog This is related to the Modlog cog. Category: Cogs - Mutes This is related to the Mutes cog. Category: Cogs - Permissions This is related to the Permissions cog. Category: Cogs - Reports This is related to the Reports cog. Category: Core - RPC/ZMQ Related to provided (provisional) API for implementing RPC in cogs labels Mar 16, 2021
@Jackenmen
Remove exception handlers that raise immediately (try-except-raise)
78bbfac
@Jackenmen
Handle incompatible overrides (arguments-differ,arguments-renamed)
0540dbc
@Jackenmen
Suppress useless-parent-delegation when override updates the docstring
62a1fd0
@Jackenmen
Fix pylint thinking nothing is returned (assignment-from-no-return)
e5a29c3
@Jackenmen
Suppress invalid-metaclass for dynamically generated metaclass type
4a6b6ce
@Jackenmen
Use raise from when raising while exception handling
645d968
@Jackenmen
Suppress false positive for cell-var-from-loop
0e78fba
@Jackenmen
Use is for comparison of command objects (comparison-with-callable)
bc37984
@Jackenmen
Fix removal of items during list iteration (modified-iterating-list)
a7ccd0a
@Jackenmen
Remove unnecessary logic for safe iteration over weakref dictionary
408406f
@Jackenmen
Stop redefining built-ins (redefined-builtin)
63a8779
@Jackenmen
Don't use bool as default in os.getenv() (invalid-envvar-default)
110a1fb
@Jackenmen
Change unnecessary bare except (E722)
c8e5ed4
@Jackenmen
Don't redefine names from outer scopes (redefined-outer-name)
8037132
@Jackenmen
Update argument name to not be a dummy name (useless-param/type-doc)
704d432
@Jackenmen
Fix missing self arguments in pytest fixtures (no-method-argument)
e7b2e02
@Jackenmen
Suppress bad-super-call for super outside the class (bad-super-call)
35a18bc
@Jackenmen
Suppress exec-used and eval-used in whole dev_commands.py file
0c359ef
@Jackenmen
Update existing suppression comments
71491ac
@Jackenmen Jackenmen force-pushed the V3/linter_stuff_reformatting branch from ce957b2 to 71491ac Compare January 19, 2023 22:48
@Flame442 Flame442 modified the milestones: 3.5.0, 3.5.1 Apr 13, 2023
@Jackenmen Jackenmen modified the milestones: 3.5.6, 3.5.7 Mar 18, 2024
@Jackenmen Jackenmen modified the milestones: 3.5.9, 3.5.10 Apr 20, 2024
@Jackenmen Jackenmen modified the milestones: 3.5.14, 3.5.x Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aikaterna aikaterna Awaiting requested review from aikaterna aikaterna is a code owner

@palmtree5 palmtree5 Awaiting requested review from palmtree5 palmtree5 is a code owner

@TrustyJAID TrustyJAID Awaiting requested review from TrustyJAID TrustyJAID is a code owner

@PredaaA PredaaA Awaiting requested review from PredaaA PredaaA will be requested when the pull request is marked ready for review PredaaA is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Category: Cogs - Admin This is related to the Admin cog. Category: Cogs - Alias This is related to the Alias cog. Category: Cogs - Audio This is related to the Audio cog. Category: Cogs - Bank (historical) This is related to the Bank cog. Category: Cogs - Cleanup This is related to the Cleanup cog. Category: Cogs - CustomCommands This is related to the CustomCommands cog. Category: Cogs - Dev This is related to the Dev cog. Category: Cogs - Downloader This is related to the Downloader cog. Category: Cogs - Economy This is related to the Economy cog. Category: Cogs - Filter This is related to the Filter cog. Category: Cogs - General This is related to the General cog. Category: Cogs - Image This is related to the Image cog. Category: Cogs - Mod This is related to the Mod cog. Category: Cogs - Modlog This is related to the Modlog cog. Category: Cogs - Mutes This is related to the Mutes cog. Category: Cogs - Permissions This is related to the Permissions cog. Category: Cogs - Reports This is related to the Reports cog. Category: Cogs - Streams This is related to the Streams cog. Category: Cogs - Trivia - Lists Changing or adding trivia lists. Category: Cogs - Trivia This is related to the Trivia cog. Category: Cogs - Warnings This is related to the Warnings cog. Category: Core - API - Bank This is related to the core Bank API. Category: Core - API - Config This is related to the `redbot.core.config` module and `redbot.core.drivers` package. Category: Core - API - Utils Package This is related to stuff in `redbot.core.utils` Category: Core - Help This is related to our help command and/or HelpFormatter API. Category: Core - i18n This is related to the i18n core API or locale files. Category: Core - Modlog This is related to the core Modlog API. Category: Core - RPC/ZMQ Related to provided (provisional) API for implementing RPC in cogs Category: Docs - Other This is related to documentation that doesn't have its dedicated label. Category: Meta This is related to the repository maintenance. Type: Bug Unexpected behavior, result, or exception. In case of PRs, it is a fix for the foregoing. Type: Enhancement Something meant to enhance existing Red features.

Projects

None yet

Milestone

3.5.x

Development

Successfully merging this pull request may close these issues.

3 participants

@Jackenmen @Drapersniper @Flame442