[Mutes] Catch failure to add or remove role #5467
Conversation
github-actions
bot
added
the
Category: Cogs - Mutes
| if guild.id in self._server_mutes: | ||
| if user.id in self._server_mutes[guild.id]: | ||
| del self._server_mutes[guild.id][user.id] | ||
| if guild.id in self._server_mutes and user.id in self._server_mutes[guild.id]: |
There was a problem hiding this comment.
if statement changed to match the one in mute_user
Jan200101
force-pushed
the
PR/mute-check
branch
from
99a4f47 to
7c99a78
Compare
redbot/cogs/mutes/mutes.py
Outdated
| if not guild.me.guild_permissions.manage_roles or role >= guild.me.top_role: | ||
| ret["reason"] = _(MUTE_UNMUTE_ISSUES["permissions_issue_role"]) | ||
| return ret | ||
| if role in user.roles: |
There was a problem hiding this comment.
As Jack stated in #5161 we should care more about [p]unmute not so much [p]mute. This would prevent updating a mute duration forcing the user to unmute and then re-apply the mute which is inconvenient.
There was a problem hiding this comment.
you make a good point.
add_roles won't fail if the user already has the role and since the user is already muted the user gets what they expected.
It might be worthwhile to add a message for updating the mute duration and printing out already muted if none is given, but this is not the point of this PR
There was a problem hiding this comment.
Here is something along the lines of what I mean (keeping the already existing text)
Jan200101
force-pushed
the
PR/mute-check
branch
from
7c99a78 to
7021e5b
Compare
Jackenmen
added
Needs Backport To 3.4
Type: Enhancement
4 participants
Closes #5161
Alternative of #5345
Description of the changes
catches
discord.errors.HTTPExceptionthrown by add_roles and remove_roles and states the user is already (un)muted