Improve heading style for sidebar #5879
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for adminlte-v4 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
@puikinsh @danny007in Can you please review these changes. I'm trying to handle headings like links are handled in the sidebar, since I faced some display issues while using them (mostly when enabling sidebar-mini)... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses a UI issue where very long headings in the sidebar component overflow their container, breaking the layout.
Problem
Currently, if a heading label is too long, it extends beyond the sidebar boundaries due to missing style constraints—unlike sidebar links, which are properly contained.
Solution
To resolve this, we apply the same
CSSproperties used for link elements, such as text overflow handling, to heading elements. This ensures long headings are truncated or wrapped appropriately, maintaining the sidebar's layout integrity.