Tests: Vitest configuration cleanup #5888
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🎭 Playwright Test Results⏰ Completed at: 10/03/2025, 03:23:27 AM UTC 📈 Summary
📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 10/03/2025, 03:12:57 AM UTC 🔗 Links🎉 Your Storybook is ready for review! |
DrJKL
force-pushed
the
drjkl/fix/vitest-configuration
branch
2 times, most recently
from
4c20481 to
98a6258
Compare
dosubot
bot
added
the
size:XXL
DrJKL
force-pushed
the
drjkl/fix/vitest-configuration
branch
from
faf43fd to
ecd3621
Compare
DrJKL
force-pushed
the
drjkl/fix/vitest-configuration
branch
from
ecd3621 to
d3f4ab9
Compare
arjansingh
reviewed
Oct 2, 2025
DrJKL
force-pushed
the
drjkl/fix/vitest-configuration
branch
from
d3f4ab9 to
f26da81
Compare
…sts (and litegraph which was its own special)
…for readonly props
DrJKL
force-pushed
the
drjkl/fix/vitest-configuration
branch
from
f26da81 to
317c81f
Compare
I'll bring them both back, though I do think the first one's been obviated by more recent design decisions, yeah. |
christian-byrne
approved these changes
Oct 3, 2025
arjansingh
pushed a commit
that referenced
this pull request
Oct 7, 2025
Simplify default scripts. Filtering is still available to users, we can revisit tagging or grouping later. This fixes the issue where we had tests that were in the codebase but never run because they weren't under `/src/components` Also deletes the duplicate litegraph tests and their associated vitest config file. - **What**: Test cleanup ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-5888-Tests-Vitest-configuration-cleanup-2806d73d36508197b800f68f0b028279) by [Unito](https://www.unito.io)
arjansingh
pushed a commit
that referenced
this pull request
Oct 7, 2025
Simplify default scripts. Filtering is still available to users, we can revisit tagging or grouping later. This fixes the issue where we had tests that were in the codebase but never run because they weren't under `/src/components` Also deletes the duplicate litegraph tests and their associated vitest config file. - **What**: Test cleanup ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-5888-Tests-Vitest-configuration-cleanup-2806d73d36508197b800f68f0b028279) by [Unito](https://www.unito.io)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Simplify default scripts. Filtering is still available to users, we can revisit tagging or grouping later.
This fixes the issue where we had tests that were in the codebase but never run because they weren't under
/src/componentsAlso deletes the duplicate litegraph tests and their associated vitest config file.
Changes
Review Focus
┆Issue is synchronized with this Notion page by Unito