WorkflowTabs: cleanup scroll/overflow handling and watcher disposal

[benceruleanlu]

Summary

Refactor and cleanup WorkflowTabs scroll/overflow handling to improve stability, ensure proper watcher disposal, and keep the active tab in view more reliably.

note: honestly a nit, can drop if review is too annoying

Changes

• What:
  • Replace ScrollPanel ref with containerRef and query .p-scrollpanel-content within the container.
  • Add computed scrollContent to centralize access to the scrollable element.
  • Add ensureActiveTabVisible({ waitForDom }) option to skip nextTick when not needed.
  • Rework watchers with explicit WatchStopHandles and onCleanup to stop previous watchers and dispose overflowObserver correctly when scrollContent changes.
  • Update arrow enable logic by watching arrivedState.left/right together and setting leftArrowEnabled/rightArrowEnabled immediately.
  • Only measure and re-ensure visibility when overflowing; call scrollState.measure() and ensureActiveTabVisible({ waitForDom: false }) after arrows update.
• Breaking: None
• Dependencies: None

Review Focus

• Correctness of watcher lifecycle and cleanup when scrollContent changes
• Arrow enablement behavior at scroll boundaries
• Reliability of ensureActiveTabVisible across tab selection and overflow changes
• Regressions in scroll performance and tab visibility

Screenshots (if applicable)

N/A

┆Issue is synchronized with this Notion page by Unito

[github-actions]

🎭 Playwright Test Results

❌ Some tests failed

⏰ Completed at: 10/17/2025, 05:52:57 PM UTC

📈 Summary

• Total Tests: 497
• Passed: 463 ✅
• Failed: 1 ❌
• Flaky: 3 ⚠️
• Skipped: 30 ⏭️

📊 Test Reports by Browser

• ✅ chromium: View Report • ✅ 454 / ❌ 1 / ⚠️ 3 / ⏭️ 30
• ✅ chromium-2x: View Report • ✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0
• ✅ chromium-0.5x: View Report • ✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0
• ✅ mobile-chrome: View Report • ✅ 6 / ❌ 0 / ⚠️ 0 / ⏭️ 0

---

🎉 Click on the links above to view detailed test results for each browser configuration.

[christian-byrne]

Did I merge in wrong order? Seems to be a conflict now.

[benceruleanlu]

Did I merge in wrong order? Seems to be a conflict now.

no the order is correct, I believe it's because it was a squash merge

fixing conflicts now fixed

[github-actions]

🎨 Storybook Build Status

✅ Build completed successfully!

⏰ Completed at: 10/17/2025, 05:37:54 PM UTC

🔗 Links

• 📊 View Workflow Run
• 🎨 View Storybook

---

🎉 Your Storybook is ready for review!

[christian-byrne]

LGTM, great PR