Skip to content

fix minimap not re-rendering when Vue nodes change mode (bypass, mute) #6110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 18, 2025
Merged

fix minimap not re-rendering when Vue nodes change mode (bypass, mute) #6110

merged 8 commits into from
Oct 18, 2025

Conversation

@christian-byrne
Copy link
Contributor

@christian-byrne christian-byrne commented Oct 17, 2025 •
edited by sync-by-unito bot
Loading

Summary

Fixes minimap not updating when node bypass/mute state changes in vue nodes mode by adding onTrigger tracking of relevant instrumented properties.

┆Issue is synchronized with this Notion page by Unito

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Oct 17, 2025
@github-actions
Copy link

github-actions bot commented Oct 17, 2025 •
edited
Loading

🎭 Playwright Test Results

❌ Some tests failed

⏰ Completed at: 10/18/2025, 10:20:27 AM UTC

📈 Summary

  • Total Tests: 498
  • Passed: 465 ✅
  • Failed: 1 ❌
  • Flaky: 2 ⚠️
  • Skipped: 30 ⏭️

📊 Test Reports by Browser

  • ✅ chromium: View Report • ✅ 456 / ❌ 1 / ⚠️ 2 / ⏭️ 30
  • ✅ chromium-2x: View Report • ✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • ✅ chromium-0.5x: View Report • ✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • ✅ mobile-chrome: View Report • ✅ 6 / ❌ 0 / ⚠️ 0 / ⏭️ 0

🎉 Click on the links above to view detailed test results for each browser configuration.

@github-actions
Copy link

github-actions bot commented Oct 17, 2025 •
edited
Loading

🎨 Storybook Build Status

✅ Build completed successfully!

⏰ Completed at: 10/18/2025, 10:02:35 AM UTC

🔗 Links

🎉 Your Storybook is ready for review!

benceruleanlu
benceruleanlu previously approved these changes Oct 17, 2025
View reviewed changes
@christian-byrne
Copy link
Contributor Author

This fixes it when using the feature, but not in tests.

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Oct 17, 2025
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Oct 17, 2025
@christian-byrne
Copy link
Contributor Author

Wow, this is depressing.

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Oct 18, 2025
@github-actions
Copy link

github-actions bot commented Oct 18, 2025 •
edited
Loading

Bundle Size Report

App Entry Points

Main application bundles

File Size Gzip Brotli
assets/index-Bp6LHe9e.js 9.67 MB 1.99 MB 1.43 MB
assets/index-CUJjuQ6S.js
assets/index-DO93jVt2.js
assets/index-PESgPnbc.js 507 B 292 B 249 B
assets/index-WHxKXYMW.js 2.02 MB 381 kB 296 kB

Category Total: 11.7 MB

Core Views

Major application views and screens

File Size Gzip Brotli
assets/GraphView-C0B4opag.js 714 kB 139 kB 108 kB
assets/GraphView-D0tMHkbu.js
assets/UserSelectView-BKsmPHJn.js 7.99 kB 2.39 kB 2.09 kB
assets/UserSelectView-uDoEFRP5.js

Category Total: 722 kB

UI Panels

Settings and configuration panels

File Size Gzip Brotli
assets/AboutPanel-BSp3lbt9.js 10.1 kB 2.58 kB 2.27 kB
assets/AboutPanel-S7bydwdW.js
assets/CreditsPanel-C5UKrK9_.js
assets/CreditsPanel-EY8cl_Y_.js 21.9 kB 5.21 kB 4.54 kB
assets/ExtensionPanel-B9usjJot.js 11.9 kB 2.74 kB 2.4 kB
assets/ExtensionPanel-ldqacsug.js
assets/KeybindingPanel-4V8ic8dz.js
assets/KeybindingPanel-npgtZ-wh.js 15.1 kB 3.68 kB 3.23 kB
assets/ServerConfigPanel-B6XF2t-u.js
assets/ServerConfigPanel-DHqAgE9b.js 8.04 kB 2.09 kB 1.84 kB
assets/UserPanel-Daa25x69.js
assets/UserPanel-Dc4fS34I.js 7.76 kB 1.97 kB 1.72 kB

Category Total: 74.8 kB

Services

Business logic and services

File Size Gzip Brotli
assets/keybindingService-BAtGwugQ.js 7.21 kB 1.75 kB 1.5 kB
assets/keybindingService-CqnJUCo-.js
assets/serverConfigStore-C1p-GgYU.js
assets/serverConfigStore-wkSAUKFG.js 2.79 kB 889 B 774 B

Category Total: 10 kB

Utilities

Helper functions and utilities

File Size Gzip Brotli
assets/mathUtil-CTARWQ-l.js 1.07 kB 525 B 452 B

Category Total: 1.07 kB

Other

Uncategorized bundles

File Size Gzip Brotli
assets/UserAvatar.vue_vue_type_script_setup_true_lang-C9bSkTC5.js 1.12 kB 577 B 494 B

Category Total: 1.12 kB

Overall Total Size: 12.5 MB
Total Bundle Count: 15

@christian-byrne
Copy link
Contributor Author

Hm, clicking the canvas works. I'll add a timeout to see whether I just need to wait generally or I need to explicitly trigger litegraph re-render

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Oct 18, 2025
@christian-byrne christian-byrne force-pushed the fix/minimap-vue-node-react-node-mode branch from 0871ff7 to 2d791e0 Compare October 18, 2025 08:54
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Oct 18, 2025
@dosubot dosubot bot removed the size:M This PR changes 30-99 lines, ignoring generated files. label Oct 18, 2025
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Oct 18, 2025
@christian-byrne christian-byrne added the New Browser Test Expectations New browser test screenshot should be set by github action label Oct 18, 2025
@github-actions
Copy link

Updating Playwright Expectations

@github-actions github-actions bot removed the New Browser Test Expectations New browser test screenshot should be set by github action label Oct 18, 2025
@christian-byrne christian-byrne force-pushed the fix/minimap-vue-node-react-node-mode branch from a50ba5f to e02c1b2 Compare October 18, 2025 10:00
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Oct 18, 2025
@christian-byrne christian-byrne added the New Browser Test Expectations New browser test screenshot should be set by github action label Oct 18, 2025
@github-actions github-actions bot removed the New Browser Test Expectations New browser test screenshot should be set by github action label Oct 18, 2025
@christian-byrne christian-byrne merged commit 2e99c39 into main Oct 18, 2025
2 checks passed
@christian-byrne christian-byrne deleted the fix/minimap-vue-node-react-node-mode branch October 18, 2025 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benceruleanlu benceruleanlu benceruleanlu left review comments

@jtydhr88 jtydhr88 Awaiting requested review from jtydhr88 jtydhr88 is a code owner

Assignees

No one assigned

Labels

area:minimap area:vue-migration size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@christian-byrne @benceruleanlu